From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6562C04A6B for ; Wed, 8 May 2019 11:37:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7761D20675 for ; Wed, 8 May 2019 11:37:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KECUZFNI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727890AbfEHLh5 (ORCPT ); Wed, 8 May 2019 07:37:57 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37493 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727579AbfEHLh4 (ORCPT ); Wed, 8 May 2019 07:37:56 -0400 Received: by mail-wr1-f66.google.com with SMTP id a12so16654371wrn.4 for ; Wed, 08 May 2019 04:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=eeVbE/nScJBLag5J/5uF3rhFiymQVd2Zd14j7hKs2Go=; b=KECUZFNIH3rYUOtX1dlvmyFlTibofR3dC0G3z4LgOfu7EL81dRHDuGbinISBewHici WTfqWBaOrepKmaPbAJab2EMLu2RaWGJ3wa3iyM7/eXcAHCDp5t34zDdlfgGdq0D77Q2m 19eRcJDyjmG6ZEfwbWO1ftM7r8fq7DFqfF87Xum9x1AHnDmhoEGCPc2qdIJTf0RaHSXT 7X1Xhk/AAoKKgjvae0fAl3bsa/jHjgZjWZIY8xlwyONYNTtN5rfYlsNhST6bqwbRRVyt PgB1Vf9FG6amQy47sGdXd/Bv9PGr92BaUTNcWL+kwxvOM0Elm9FVE9p9IMpDMO+bFXs8 5Hmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=eeVbE/nScJBLag5J/5uF3rhFiymQVd2Zd14j7hKs2Go=; b=HDguBQVPkBrN5PjTQi6cQtrxeaBTPtJri54+gHidklzf7E2rOQk86XSXn3yusWzAAM ji4qGe9AKwf5xBAdaSH1Fvucq9vB6zMCypKlZnh7IbM4VyD4asJ62X3qQGaeXc4rGuRa aIFftPRH+JayzmJk3CCu2E9l7Zor6F6cYKnVw7/DWdh1A68rWsSCnbgw2XF32dEJc/jV ROEUD2NpebzvPCJWO7b86rWrU6RnDfUmyENbc1Jz6rhAgzCxaKo6QmCXK/OORA2tdDJn BSH20Mq2p68jK/S7QiDfhd2kCvLlYchP4ghqq2hDje/NDEYQ8LWISR+onSZymeWT1qsm 5Vnw== X-Gm-Message-State: APjAAAUV4/NGIqatgg7rm9z/DL0XDpBr3K8wETK4y6Z8Sln77ZEbNq4y 2UlBcL4cCaP7f2WmQIxwvLGHIw== X-Google-Smtp-Source: APXvYqylJd9JgQDs4no8oS1ib+tuQIB3A9RO89mbhrVWeCUcsCxdG1V6qUglLUHQmf1jJlbVfEJ7/g== X-Received: by 2002:adf:eb8e:: with SMTP id t14mr5248477wrn.113.1557315475173; Wed, 08 May 2019 04:37:55 -0700 (PDT) Received: from dell ([2.27.167.43]) by smtp.gmail.com with ESMTPSA id l21sm1379871wmh.35.2019.05.08.04.37.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 May 2019 04:37:54 -0700 (PDT) Date: Wed, 8 May 2019 12:37:52 +0100 From: Lee Jones To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Stephen Rothwell , Alexey Gladkov , linux-kernel@vger.kernel.org, Thomas Gleixner , Tony Lindgren , Aaro Koskinen , linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Daniel Lezcano Subject: Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro Message-ID: <20190508113752.GE31645@dell> References: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 May 2019, Masahiro Yamada wrote: > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be > successfully compiled because they are never built as a module by > anyone, i.e, the MODULE_ALIAS() calls are always no-op. > > A problem showed up when a patch "moduleparam: Save information about > built-in modules in separate file" is applied. With this new feature, > MODULE_*() are populated even if the callers are built-in. > > To avoid the build errors, the lines referencing to the undefined > macro must be removed. > > The complete fix is to remove all MODULE_* and #include > like many "make ... explicitly non-modular" commits did. > > For now, I am touching the offending lines. > > Reported-by: Stephen Rothwell > Signed-off-by: Masahiro Yamada > --- > > I will insert this commit before > "moduleparam: Save information about built-in modules in separate file" > > > arch/arm/plat-omap/dma.c | 1 - > drivers/clocksource/timer-ti-dm.c | 1 - > drivers/mfd/omap-usb-tll.c | 1 - For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog