From: Antonio Borneo <borneo.antonio@gmail.com>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS
Date: Wed, 8 May 2019 14:27:19 +0200 [thread overview]
Message-ID: <20190508122721.7513-2-borneo.antonio@gmail.com> (raw)
In-Reply-To: <20190508122721.7513-1-borneo.antonio@gmail.com>
The warning LINE_CONTINUATIONS does not offer a --fix.
Add the trivial --fix.
In case of consecutive lines with the same issue, this will
fix only the first line.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
scripts/checkpatch.pl | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f40d4bb2fbb9..9a247183b65c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5207,8 +5207,11 @@ sub process {
$line !~ /^\+\s*\#.*\\$/ && # preprocessor
$line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ && # asm
$line =~ /^\+.*\\$/) {
- WARN("LINE_CONTINUATIONS",
- "Avoid unnecessary line continuations\n" . $herecurr);
+ if (WARN("LINE_CONTINUATIONS",
+ "Avoid unnecessary line continuations\n" . $herecurr) &&
+ $fix) {
+ $fixed[$fixlinenr] =~ s/\s*\\$//;
+ }
}
}
--
2.21.0
next prev parent reply other threads:[~2019-05-08 12:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 12:27 [PATCH 1/4] checkpatch: fix multiple const * types Antonio Borneo
2019-05-08 12:27 ` Antonio Borneo [this message]
2019-05-08 14:19 ` [PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS Joe Perches
2019-05-08 12:27 ` [PATCH 3/4] checkpatch: fix minor typo and mixed space+tab in indentation Antonio Borneo
2020-01-22 16:38 ` [PATCH V2] " Antonio Borneo
2020-01-22 17:26 ` Joe Perches
2019-05-08 12:27 ` [PATCH 4/4] checkpatch: replace magic value for TAB size Antonio Borneo
2019-05-08 14:52 ` Joe Perches
2019-05-08 15:32 ` Antonio Borneo
2019-05-08 17:02 ` Joe Perches
2020-01-22 16:38 ` [PATCH V6] checkpatch: add command-line option " Antonio Borneo
2019-05-08 14:51 ` [PATCH 1/4] checkpatch: fix multiple const * types Joe Perches
2019-05-08 15:26 ` Antonio Borneo
2019-05-08 17:43 ` [PATCH v2] " Antonio Borneo
2019-09-04 9:37 ` Antonio Borneo
2020-01-22 16:38 ` [PATCH V3] " Antonio Borneo
-- strict thread matches above, loose matches on Subject: below --
2019-05-08 17:43 [PATCH v2] checkpatch: add command-line option for TAB size Antonio Borneo
2019-05-08 17:56 ` Joe Perches
2019-05-08 18:19 ` Antonio Borneo
2019-05-08 18:36 ` [PATCH v3] " Antonio Borneo
2019-05-08 21:14 ` [PATCH v2] " Elliott, Robert (Servers)
2019-05-08 21:59 ` Joe Perches
2019-05-08 22:03 ` Antonio Borneo
2019-05-09 7:21 [PATCH v4] " Antonio Borneo
2019-05-09 8:03 ` Joe Perches
2019-05-09 9:26 ` Antonio Borneo
2019-05-09 9:39 ` [PATCH v5] " Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508122721.7513-2-borneo.antonio@gmail.com \
--to=borneo.antonio@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox