From: Greg KH <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: PanBian <bianpan2016@163.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] EDAC/sysfs: Drop device references properly
Date: Wed, 8 May 2019 14:47:38 +0200 [thread overview]
Message-ID: <20190508124738.GC8646@kroah.com> (raw)
In-Reply-To: <20190508110605.GE19015@zn.tnic>
On Wed, May 08, 2019 at 01:06:05PM +0200, Borislav Petkov wrote:
> --
> From: Greg KH <gregkh@linuxfoundation.org>
>
> Do put_device() if device_add() fails.
>
> [ bp: do device_del() for the successfully created devices in
> edac_create_csrow_objects(), on the unwind path. ]
Yes, good catch, looks good, thanks!
greg k-h
prev parent reply other threads:[~2019-05-08 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 2:27 EDAC: Fix memory leak in creating CSROW object Pan Bian
2019-04-18 17:25 ` Borislav Petkov
[not found] ` <20190419003536.GA57795@bianpan2016@163.com>
2019-04-19 0:45 ` Borislav Petkov
2019-04-27 21:49 ` Greg KH
2019-05-08 10:57 ` Borislav Petkov
2019-05-08 12:47 ` Greg KH
2019-05-08 18:50 ` Borislav Petkov
2019-05-08 11:02 ` [PATCH 1/2] EDAC/sysfs: Fix memory leak when creating a csrow object Borislav Petkov
2019-05-08 12:45 ` Greg KH
2019-05-08 11:06 ` [PATCH 2/2] EDAC/sysfs: Drop device references properly Borislav Petkov
2019-05-08 12:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508124738.GC8646@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bianpan2016@163.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox