From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CFFC04AAD for ; Wed, 8 May 2019 12:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BCB521019 for ; Wed, 8 May 2019 12:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557319662; bh=dnvIXgHZ2nj3mMk0IxGgiKgWOqscukd4p+bqGXdACeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Q5R81hKwHk3HJim3bkvb/IulbVdE4Ee3Qz8/a45JfoiM6AZDo40e6+P+lJRjde71Z 4ReeBnAn01Y5nzJZbChEKwmoN8c38HdcI/RX1gWZRffeWtQinXQdn1Mu7+G/tCaCdQ SqvIn0fciZcar82izr4Eiucd9LmzhWQ8lHhvtk1I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728665AbfEHMrl (ORCPT ); Wed, 8 May 2019 08:47:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:34276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbfEHMrl (ORCPT ); Wed, 8 May 2019 08:47:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29A4620644; Wed, 8 May 2019 12:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557319660; bh=dnvIXgHZ2nj3mMk0IxGgiKgWOqscukd4p+bqGXdACeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SsduZ/NZYINzSM0PwseSZGuZCr1lxjgTY4zcngITEXQbYQ5LAAVHjuXTGOXkZO7oM Cd82T/Hasjc6Uoa9XByq+oIBghtUe9TiEq04EHSaPTNNV3FJcfggSFrzYAY9YJcCHw HUnLabX0Hh3N/z6D3VEwbRhF1CZi/++b9CsJwR6E= Date: Wed, 8 May 2019 14:47:38 +0200 From: Greg KH To: Borislav Petkov Cc: PanBian , Mauro Carvalho Chehab , James Morse , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] EDAC/sysfs: Drop device references properly Message-ID: <20190508124738.GC8646@kroah.com> References: <1555554438-103953-1-git-send-email-bianpan2016@163.com> <20190418172548.GL27160@zn.tnic> <20190419003536.GA57795@bianpan2016@163.com> <20190419004516.GC559@zn.tnic> <20190427214925.GE16338@kroah.com> <20190508110605.GE19015@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190508110605.GE19015@zn.tnic> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 08, 2019 at 01:06:05PM +0200, Borislav Petkov wrote: > -- > From: Greg KH > > Do put_device() if device_add() fails. > > [ bp: do device_del() for the successfully created devices in > edac_create_csrow_objects(), on the unwind path. ] Yes, good catch, looks good, thanks! greg k-h