From: "Luck, Tony" <tony.luck@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>, Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC, sb_edac: remove redundant update of tad_base
Date: Wed, 8 May 2019 15:48:07 -0700 [thread overview]
Message-ID: <20190508224807.GA25404@agluck-desk> (raw)
In-Reply-To: <20190508224201.27120-1-colin.king@canonical.com>
On Wed, May 08, 2019 at 11:42:01PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable tad_base is being set to a value that is never read
> and is being over-written on the next iteration of a for-loop.
> This assignment is therefore redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/edac/sb_edac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 9353c3fc7c05..6aa4b1b73a15 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -1513,7 +1513,6 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes)
> sad_actual_size[mc] += tad_size;
> }
> }
> - tad_base = tad_limit+1;
> }
> }
>
Looks good to me.
Acked-by: Tony Luck <tony.luck@intel.com>
next prev parent reply other threads:[~2019-05-08 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 22:42 [PATCH] EDAC, sb_edac: remove redundant update of tad_base Colin King
2019-05-08 22:48 ` Luck, Tony [this message]
2019-05-09 14:13 ` Borislav Petkov
2019-05-09 14:29 ` Colin Ian King
2019-05-09 14:41 ` Borislav Petkov
2019-05-09 14:46 ` Dan Carpenter
2019-05-09 14:54 ` Borislav Petkov
2019-05-09 14:55 ` Colin Ian King
2019-05-09 15:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508224807.GA25404@agluck-desk \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox