The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jim Lin <jilin@nvidia.com>
Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu,
	kai.heng.feng@canonical.com, drinkcat@chromium.org,
	keescook@chromium.org, nsaenzjulienne@suse.de,
	jflat@chromium.org, malat@debian.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/1] usb: xhci: Add Clear_TT_Buffer
Date: Thu, 9 May 2019 14:25:34 +0200	[thread overview]
Message-ID: <20190509122534.GA31542@kroah.com> (raw)
In-Reply-To: <1557403395-30877-1-git-send-email-jilin@nvidia.com>

On Thu, May 09, 2019 at 08:03:15PM +0800, Jim Lin wrote:
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -625,6 +625,7 @@ struct usb3_lpm_parameters {
>   *		parent->hub_delay + wHubDelay + tTPTransmissionDelay (40ns)
>   *
>   *	Will be used as wValue for SetIsochDelay requests.
> + * @devaddr: address on a USB bus, assigned by controller like XHCI
>   *
>   * Notes:
>   * Usbcore drivers should not set usbdev->state directly.  Instead use
> @@ -709,6 +710,7 @@ struct usb_device {
>  	unsigned lpm_disable_count;
>  
>  	u16 hub_delay;
> +	int devaddr;

Shouldn't this be u32?



  reply	other threads:[~2019-05-09 12:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 12:03 [PATCH v7 1/1] usb: xhci: Add Clear_TT_Buffer Jim Lin
2019-05-09 12:25 ` Greg KH [this message]
2019-05-09 14:31   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190509122534.GA31542@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=drinkcat@chromium.org \
    --cc=jflat@chromium.org \
    --cc=jilin@nvidia.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=mathias.nyman@intel.com \
    --cc=nsaenzjulienne@suse.de \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox