From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E97C04AB3 for ; Thu, 9 May 2019 14:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A906A21479 for ; Thu, 9 May 2019 14:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557411163; bh=gvXtCwB0sLdrpt5goC5N5snphtui02QgZflWutuvxYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zu28NW8W1gt8+Nz0qBpBRRF5y0NW3aRZoJR+3bIWPS92cRFp/IXMPvAymkWUuAp8S RtsBvr1cXCf6MW0V98muyowKeLOQ3bqaeOjsJ75RDUkBaPVjzRhXCTQr/CgqF1AQhV EV9gZM5xxRHLtEmkst6VnDL/jfQruREYYDSql8Nc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbfEIOMm (ORCPT ); Thu, 9 May 2019 10:12:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:48732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfEIOMm (ORCPT ); Thu, 9 May 2019 10:12:42 -0400 Received: from localhost (50-81-63-4.client.mchsi.com [50.81.63.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FC7C2085A; Thu, 9 May 2019 14:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557411161; bh=gvXtCwB0sLdrpt5goC5N5snphtui02QgZflWutuvxYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W8Cm60yZvIcQo+buFJ5EdbA/DOIxuuSxZIrEx1Q1iwB3KNptgpqKfLr2ot/qAwKN2 2RHmLiDfnuJywOuNzxA96yC/TC1gsyNpvWbVCp+Hq4Q6FTYDA0+Frw0RI8LazilqaW nu7sj+DjlZls42Kad5oqlFclWRYZTxat/+YKL+ZA= Date: Thu, 9 May 2019 09:12:40 -0500 From: Bjorn Helgaas To: Frederick Lawler Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, lukas@wunner.de, andriy.shevchenko@linux.intel.com, keith.busch@intel.com, mr.nuke.me@gmail.com, liudongdong3@huawei.com, thesven73@gmail.com Subject: Re: [PATCH v2 4/9] PCI/LINK: Prefix dmesg logs with PCIe service name Message-ID: <20190509141240.GB88424@google.com> References: <20190503035946.23608-1-fred@fredlawl.com> <20190503035946.23608-5-fred@fredlawl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503035946.23608-5-fred@fredlawl.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 10:59:41PM -0500, Frederick Lawler wrote: > bw_notification.c currently does not have any dmesg logs. As the > service continues to expand in functionality, prefix logs anyways. > > Signed-off-by: Frederick Lawler > --- > drivers/pci/pcie/bw_notification.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/pcie/bw_notification.c b/drivers/pci/pcie/bw_notification.c > index d2eae3b7cc0f..a4bb90562cd5 100644 > --- a/drivers/pci/pcie/bw_notification.c > +++ b/drivers/pci/pcie/bw_notification.c > @@ -14,6 +14,8 @@ > * and warns when links become degraded in operation. > */ > > +#define dev_fmt(fmt) "BWN: " fmt I think I'd drop this patch until it's needed. > #include "../pci.h" > #include "portdrv.h" > > -- > 2.17.1 >