From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A90C04AB3 for ; Thu, 9 May 2019 14:58:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C24B2054F for ; Thu, 9 May 2019 14:58:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="owM2FhNd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbfEIO66 (ORCPT ); Thu, 9 May 2019 10:58:58 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:33321 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbfEIO66 (ORCPT ); Thu, 9 May 2019 10:58:58 -0400 Received: by mail-pf1-f195.google.com with SMTP id z28so1475095pfk.0 for ; Thu, 09 May 2019 07:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O2GVNaaLG3l4A7SJYHvhzrnNiIlglRkSlpfGLRzuylM=; b=owM2FhNdQD3/AZ1QZczHAcumqaO62cKOzbcn0wo0srjYi0aJmUbBO5bCn3V5VdxSW0 74bIGkNFPqUHT5SLQKJGibcflH3UxMzbGuy/ZLbtw3AWBpjuTmllygACfswKRryWDjEE 7FcJwiuwkwdH1xJVyPDY4c7MOjCMsvjM4VqFrUofJd5m4BugNQLB0TGzkcZTS0NxFG5W gUx85r8q9Gaagdgm41Zl2bDJt0YcjeOL130nHdSgAww8zP5BX5jpgAA4uU9e3Gm3G3zz eozMavbAcKt3BHMsIdWIzk9olc+36VygZOIVr2T4PcDWEbeEIGlQGCM9CfctVEo1LPIp Y8Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O2GVNaaLG3l4A7SJYHvhzrnNiIlglRkSlpfGLRzuylM=; b=DZx+xSPMN/PjOI3HFbExDkTP7qpEDpzmcTSwOjvJkwS949AYRfeZOQbX3EtowUGQee NVZzRtyV5rBNcbVAAb2yjO9Dpa3PC9Uuklf9W63vWE3j7q9Bkl6DMBiPDycDuuT0bvl1 Z8MVTakndeuI/vlaTXLzpvJjRpbcHuF6M9xue3qcwdTt4JvPVHs9OLp0aE/E6k5gpNqo gN0SeaweiU/bTQIY1HIvW1psmiFtsHLzs30bh0ExD5MBnN3XnIcljS38jzszb4XZQ1ZC FVv8etChTZ4E7V3Q5LjZJFkL8Kh7GHyqpQmalS3qzT319SA0bnHKsLrKOoVkaVlolFuV t2OA== X-Gm-Message-State: APjAAAVDPlzVcWpNbyrvaFbzCfQNhnTev54sse7Oong4Jb2uodvYPpPP YyWWg+7guZloOkUNIO3eYiUoWQ== X-Google-Smtp-Source: APXvYqzB08jbRTCZn/COGHwU59Jhcv8+bRZwlqaOwdUaHe25RZJvtDJY+ALgBmzW3A/k0UdMggom9w== X-Received: by 2002:a62:1b8a:: with SMTP id b132mr5780183pfb.19.1557413936856; Thu, 09 May 2019 07:58:56 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g10sm6438908pfg.153.2019.05.09.07.58.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 May 2019 07:58:55 -0700 (PDT) Date: Thu, 9 May 2019 07:59:12 -0700 From: Bjorn Andersson To: Brian Masney Cc: Rob Clark , Sean Paul , dri-devel , linux-arm-msm , freedreno , David Airlie , Daniel Vetter , Linux Kernel Mailing List , Linus Walleij Subject: Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support Message-ID: <20190509145912.GG2085@tuxbook-pro> References: <20190505130413.32253-1-masneyb@onstation.org> <20190505130413.32253-5-masneyb@onstation.org> <20190507063902.GA2085@tuxbook-pro> <20190509021616.GA26228@basecamp> <20190509030047.GE2085@tuxbook-pro> <20190509071243.GA27143@basecamp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190509071243.GA27143@basecamp> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 09 May 00:12 PDT 2019, Brian Masney wrote: > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > > > > > On Sun 05 May 06:04 PDT 2019, Brian Masney wrote: > > > > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi > > > > > [..] > > > > > > + clocks = <&mmcc MDSS_MDP_CLK>, > > > > > > + <&mmcc MDSS_AHB_CLK>, > > > > > > + <&mmcc MDSS_AXI_CLK>, > > > > > > + <&mmcc MDSS_BYTE0_CLK>, > > > > > > + <&mmcc MDSS_PCLK0_CLK>, > > > > > > + <&mmcc MDSS_ESC0_CLK>, > > > > > > + <&mmcc MMSS_MISC_AHB_CLK>; > > > > > > + clock-names = "mdp_core", > > > > > > + "iface", > > > > > > + "bus", > > > > > > + "byte", > > > > > > + "pixel", > > > > > > + "core", > > > > > > + "core_mmss"; > > > > > > > > > > Unless I enable MMSS_MMSSNOC_AXI_CLK and MMSS_S0_AXI_CLK I get some > > > > > underrun error from DSI. You don't see anything like this? > > > > > > > > > > (These clocks are controlled by msm_bus downstream and should be driven > > > > > by interconnect upstream) > > > > > > > > > > > > > > > Apart from this, I think this looks nice. Happy to see the progress. > > > > > > > > No, I'm not seeing an underrun errors from the DSI. I think the clocks > > > > are fine since I'm able to get this working with 4.17 using these same > > > > clocks. I just sent out v2 and the cover letter has some details, along > > > > with the full dmesg. > > > > > > since we don't have interconnect driver for 8974, I guess there is > > > some chance that things work or not based on how lk leaves things? > > > > > > > Right, I guess the bootloader on my device does not leave the busses > > ticking - perhaps there's a boot splash involved on Brian's device? > > > > Regardless, this works on Nexus 5 and allows Brian to make further > > progress so I'm all for merging it. > > There is a boot splash on the Nexus 5 and that may explain a behavior > that I observed. I attempted to add reset GPIO support to the simple > panel driver and the screen will clear but nothing will come on the > screen after a hard reset, even on 4.17. To be sure, I got the timing > information for how long to leave the GPIO high and low from the > downstream MSM 3.4 sources. That's when I had a script port all of the > ~400 panel on commands in the downstream device tree to a new panel > driver. > > With the latest kernel kernel having a delay showing the console text, > I observe a brief second where the boot splash is shown along with the > startup text from Linux. A full refresh is performed and the boot > splash goes away. I don't see this with the 4.17 kernel; perhaps maybe > the full refresh occurs quick enough that its not noticeable. > > Can you point me to where the interconnect API is in the downstream > MSM 3.4 sources? https://github.com/AICP/kernel_lge_hammerhead > It looks like its in drivers/interconnect/ in the upstream sources. > The data will be 8974 specific, but the plumbing should be reusable from 8916 or 404. Hopefully we can get those landed shortly. You can find the latest incarnation here: https://lore.kernel.org/lkml/20190415104357.5305-1-georgi.djakov@linaro.org/ Regards, Bjorn