From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1040C04AB4 for ; Thu, 9 May 2019 18:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90609217F5 for ; Thu, 9 May 2019 18:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427763; bh=LyCe6t84GgXISN5cnVOrl5RwD73RD19YTAuhGeaItwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=i/LytSDWG8la+3m8EzkHxM88Pl10bl1875ejBv9xROwB4ueF45y28aqt+zGkEmaPv L7RvFMa5LnpIXY0AJD3G8XgeLkkySvqijQZHX7ZkCBnfzPMd6EJ6HBqmnIUkhq+Yin YgugoZGC2lNUmn0Bc8yK8MqPwNyEr2eyB2oNphZA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728200AbfEIStW (ORCPT ); Thu, 9 May 2019 14:49:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:42604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfEIStU (ORCPT ); Thu, 9 May 2019 14:49:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFCA9217F5; Thu, 9 May 2019 18:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427759; bh=LyCe6t84GgXISN5cnVOrl5RwD73RD19YTAuhGeaItwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IM9UYDk5DpN0t/992wxBYG09Az9gQgpEygjeP1YNia3iDFqZPOFpsytZMpIRP8w+H CfJ94wV+l2LfyMrozTJ6YtjuVul6WWRyuTMewurvjW3yx4zmk24ByeGCXk0DAR8iaA al45oA8P5qbXXbuqgxLlEwdZ3LEiOgEmmbeL5CW0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , "Ewan D. Milne" , "Martin K. Petersen" Subject: [PATCH 4.19 60/66] scsi: qla2xxx: Fix device staying in blocked state Date: Thu, 9 May 2019 20:42:35 +0200 Message-Id: <20190509181307.754166157@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181301.719249738@linuxfoundation.org> References: <20190509181301.719249738@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Quinn Tran commit 2137490f2147a8d0799b72b9a1023efb012d40c7 upstream. This patch fixes issue reported by some of the customers, who discovered that after cable pull scenario the devices disappear and path seems to remain in blocked state. Once the device reappears, driver does not seem to update path to online. This issue appears because of the defer flag creating race condition where the same session reappears. This patch fixes this issue by indicating SCSI-ML of device lost when qlt_free_session_done() is called from qlt_unreg_sess(). Fixes: 41dc529a4602a ("qla2xxx: Improve RSCN handling in driver") Signed-off-by: Quinn Tran Cc: stable@vger.kernel.org #4.19 Signed-off-by: Himanshu Madhani Reviewed-by: Ewan D. Milne Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -981,6 +981,8 @@ void qlt_free_session_done(struct work_s sess->send_els_logo); if (!IS_SW_RESV_ADDR(sess->d_id)) { + qla2x00_mark_device_lost(vha, sess, 0, 0); + if (sess->send_els_logo) { qlt_port_logo_t logo; @@ -1161,8 +1163,6 @@ void qlt_unreg_sess(struct fc_port *sess if (sess->se_sess) vha->hw->tgt.tgt_ops->clear_nacl_from_fcport_map(sess); - qla2x00_mark_device_lost(vha, sess, 0, 0); - sess->deleted = QLA_SESS_DELETION_IN_PROGRESS; sess->disc_state = DSC_DELETE_PEND; sess->last_rscn_gen = sess->rscn_gen;