From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42A7C04AB1 for ; Thu, 9 May 2019 18:54:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA25D204FD for ; Thu, 9 May 2019 18:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557428041; bh=7t0QL+p2HleZpA6aEqBZLYEj57sH7+evSfFq7NUp3Mk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PZqJqolnb/gqhRUccF2hLERDEPZbH8cQhURc2eY6md03+gAHVST9NtvRWH9b34AUe kh6vKwXqONhLgzKVI4L3lVGk/g+d95S7wDfpnrZkJyaPS4GMMCuAvClE43QlspPryp ZP7rI8pv0NXNUzoj/1seNsFeBhtwECenNPCCuCT4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728979AbfEISyA (ORCPT ); Thu, 9 May 2019 14:54:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:48554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728746AbfEISx6 (ORCPT ); Thu, 9 May 2019 14:53:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3597217D6; Thu, 9 May 2019 18:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557428037; bh=7t0QL+p2HleZpA6aEqBZLYEj57sH7+evSfFq7NUp3Mk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dFpHWc0YM2eQ2fYR0cE2Ei5LZ65/j+WRuURWqUiAffCYd9mwFJi4Djlrmqaqxkq6i UA705GW5lRJOR9E+FaDFn43kIlgCGK3XqlspOKgaQ82Bvo/K+9td6tuEDCg3cc52h1 Aikuyyw7BGcwM7kjYdZgDlpzwfe2n9QWleAjc6ug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Prasad Sodagudi , Thomas Gleixner , marc.zyngier@arm.com, Sasha Levin Subject: [PATCH 5.0 73/95] genirq: Prevent use-after-free and work list corruption Date: Thu, 9 May 2019 20:42:30 +0200 Message-Id: <20190509181314.515316121@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181309.180685671@linuxfoundation.org> References: <20190509181309.180685671@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 59c39840f5abf4a71e1810a8da71aaccd6c17d26 ] When irq_set_affinity_notifier() replaces the notifier, then the reference count on the old notifier is dropped which causes it to be freed. But nothing ensures that the old notifier is not longer queued in the work list. If it is queued this results in a use after free and possibly in work list corruption. Ensure that the work is canceled before the reference is dropped. Signed-off-by: Prasad Sodagudi Signed-off-by: Thomas Gleixner Cc: marc.zyngier@arm.com Link: https://lkml.kernel.org/r/1553439424-6529-1-git-send-email-psodagud@codeaurora.org Signed-off-by: Sasha Levin --- kernel/irq/manage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 84b54a17b95d3..df557ec20a6f9 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -356,8 +356,10 @@ irq_set_affinity_notifier(unsigned int irq, struct irq_affinity_notify *notify) desc->affinity_notify = notify; raw_spin_unlock_irqrestore(&desc->lock, flags); - if (old_notify) + if (old_notify) { + cancel_work_sync(&old_notify->work); kref_put(&old_notify->kref, old_notify->release); + } return 0; } -- 2.20.1