Re: [PATCH 5/5] IB/hfi1: Fix improper uses of smp_mb__before_atomic()

Dennis Dalessandro
2019-05-14T12:32:56Z

On 5/9/2019 5:12 PM, Andrea Parri wrote:
> On Tue, Apr 30, 2019 at 01:16:57AM +0200, Andrea Parri wrote:
>> Hi Mike,
>>
>>>> This barrier only applies to the read-modify-write operations; in
>>>> particular, it does not apply to the atomic_read() primitive.
>>>>
>>>> Replace the barrier with an smp_mb().
>>>
>>> This is one of a couple of barrier issues that we are currently looking into.
>>>
>>> See:
>>>
>>> [PATCH for-next 6/9] IB/rdmavt: Add new completion inline
>>>
>>> We will take a look at this one as well.
>>
>> Thank you for the reference and for looking into this,
>
> So, I'm planning to just drop this patch; or can I do something to help?
>
> Please let me know.

Mike was looking into this, and I've got a handful of patches from him
to review. He's unavailable for a while but if it's not included in the
patches I've got we'll get something out shortly. So yes I think we can
hold off on this patch for now. Thanks.

-Denny