From: Greg KH <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ulf Magnusson <ulfalizer@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig: do not write .config if the content is the same
Date: Fri, 10 May 2019 08:21:16 +0200 [thread overview]
Message-ID: <20190510062116.GA18014@kroah.com> (raw)
In-Reply-To: <20190510061205.28753-2-yamada.masahiro@socionext.com>
On Fri, May 10, 2019 at 03:12:05PM +0900, Masahiro Yamada wrote:
> Kconfig updates the .config when it exits even if its content is
> exactly the same as before. Since its timestamp becomes newer than
> that of other build artifacts, additional processing is invoked,
> which is annoying.
>
> - syncconfig is invoked to update include/config/auto.conf, etc.
>
> - kernel/config.o is recompiled if CONFIG_IKCONFIG is enabled,
> then vmlinux is relinked as well.
>
> If the .config is not changed at all, we do not have to even
> touch it. Just bail out showing "No change to .config".
>
> $ make allmodconfig
> scripts/kconfig/conf --allmodconfig Kconfig
> #
> # configuration written to .config
> #
> $ make allmodconfig
> scripts/kconfig/conf --allmodconfig Kconfig
> #
> # No change to .config
> #
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org> ?
:)
Anyway, nice change, looks good to me:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-05-10 6:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 6:12 [PATCH 1/2] kconfig: do not accept a directory for configuration output Masahiro Yamada
2019-05-10 6:12 ` [PATCH 2/2] kconfig: do not write .config if the content is the same Masahiro Yamada
2019-05-10 6:21 ` Greg KH [this message]
2019-05-10 7:14 ` Masahiro Yamada
2019-05-10 6:46 ` Geert Uytterhoeven
2019-05-10 7:03 ` Sam Ravnborg
2019-05-10 7:24 ` Geert Uytterhoeven
2019-05-10 7:41 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510062116.GA18014@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox