From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD58C04AB3 for ; Fri, 10 May 2019 06:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6846217F4 for ; Fri, 10 May 2019 06:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557469281; bh=Z66d2Vn2xlb9VjxzpZ2kAEvngB+d1lg50Gc6MnTLXCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HIPNvg7Ok/jO1Nx9kQM0tIsGRsRh3bGGlyJ5dKAaaLsJQ5CAiZ4+tvBwFvnt3Z5n7 LekzY1M3kXagvBcsA0VWW7B8t1Lr/tub0CrmgUW2paFhJjpe+tVlcMx3dVtrgoGrmL O7wxa1c8Sv2B4Jl+VHq+sk36/ZuI/nWrB4ZRXQNM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbfEJGVU (ORCPT ); Fri, 10 May 2019 02:21:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:53738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbfEJGVT (ORCPT ); Fri, 10 May 2019 02:21:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8BC732175B; Fri, 10 May 2019 06:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557469279; bh=Z66d2Vn2xlb9VjxzpZ2kAEvngB+d1lg50Gc6MnTLXCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xMm1u3gLqIRjl1JDOc/aQToGdtS1yf9wH5p6NXoiOJ6GIAfL/MlWSfoZLMlMPiw0q j2N3/tce0TuE+4T5FjhNcApDT2P7lprAbXl/IxyvOZoJaSzviG0dv0VHzzJkHR75Kp EnuzW4vfTRHs8y7IR4M1Zpvbbqs7fv+EQDbRNkW8= Date: Fri, 10 May 2019 08:21:16 +0200 From: Greg KH To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Andrew Morton , Ulf Magnusson , Linus Torvalds , Joel Fernandes , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] kconfig: do not write .config if the content is the same Message-ID: <20190510062116.GA18014@kroah.com> References: <20190510061205.28753-1-yamada.masahiro@socionext.com> <20190510061205.28753-2-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190510061205.28753-2-yamada.masahiro@socionext.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 03:12:05PM +0900, Masahiro Yamada wrote: > Kconfig updates the .config when it exits even if its content is > exactly the same as before. Since its timestamp becomes newer than > that of other build artifacts, additional processing is invoked, > which is annoying. > > - syncconfig is invoked to update include/config/auto.conf, etc. > > - kernel/config.o is recompiled if CONFIG_IKCONFIG is enabled, > then vmlinux is relinked as well. > > If the .config is not changed at all, we do not have to even > touch it. Just bail out showing "No change to .config". > > $ make allmodconfig > scripts/kconfig/conf --allmodconfig Kconfig > # > # configuration written to .config > # > $ make allmodconfig > scripts/kconfig/conf --allmodconfig Kconfig > # > # No change to .config > # > > Signed-off-by: Masahiro Yamada Reported-by: Linus Torvalds ? :) Anyway, nice change, looks good to me: Reviewed-by: Greg Kroah-Hartman