From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3CCEC04AB1 for ; Sat, 11 May 2019 11:01:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C07F7217F9 for ; Sat, 11 May 2019 11:01:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728550AbfEKLBk (ORCPT ); Sat, 11 May 2019 07:01:40 -0400 Received: from static.187.34.201.195.clients.your-server.de ([195.201.34.187]:34684 "EHLO sysam.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728512AbfEKLBj (ORCPT ); Sat, 11 May 2019 07:01:39 -0400 Received: from localhost (localhost [127.0.0.1]) by sysam.it (Postfix) with ESMTP id 0821B3FE9A; Sat, 11 May 2019 12:55:41 +0200 (CEST) Received: from sysam.it ([127.0.0.1]) by localhost (mail.sysam.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jqyj6kYSd3xh; Sat, 11 May 2019 12:55:40 +0200 (CEST) Received: from jerusalem (host87-8-dynamic.4-87-r.retail.telecomitalia.it [87.4.8.87]) by sysam.it (Postfix) with ESMTPSA id 6C8FF3FBE6; Sat, 11 May 2019 12:55:40 +0200 (CEST) Date: Sat, 11 May 2019 12:55:39 +0200 From: Angelo Dureghello To: Arnd Bergmann Cc: Geert Uytterhoeven , Greg Ungerer , Logan Gunthorpe , linux-m68k , Linux Kernel Mailing List Subject: Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals Message-ID: <20190511105539.GA20920@jerusalem> References: <20190429081937.7544-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Apr 29, 2019 at 02:39:47PM +0200, Arnd Bergmann wrote: > On Mon, Apr 29, 2019 at 10:19 AM Geert Uytterhoeven > wrote: > > > > The generic definitions of mmio_{read,write}{16,32}be() in lib/iomap.c > > assume that the {read,write}[wl]() I/O accessors always use little > > endian accesses, and swap the result. > > > > However, the Coldfire versions of the {read,write}[wl]() I/O accessors are > > special, in that they use native big endian instead of little endian for > > accesses to the on-SoC peripheral block, thus violating the assumption. > > > > Fix this by providing our own variants, using the raw accessors, > > reinstating the old behavior. This is fine on m68k, as no special > > barriers are needed, and also avoids swapping data twice. > > > > Reported-by: Angelo Dureghello > > Fixes: aecc787c06f4300f ("iomap: Use non-raw io functions for io{read|write}XXbe") > > Signed-off-by: Geert Uytterhoeven > > --- > > This can be reverted later, after this oddity of the Coldfire I/O > > support has been fixed, and drivers have been updated. > > --- > > arch/m68k/include/asm/io.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/m68k/include/asm/io.h b/arch/m68k/include/asm/io.h > > index aabe6420ead2a599..d47e7384681ab1cd 100644 > > --- a/arch/m68k/include/asm/io.h > > +++ b/arch/m68k/include/asm/io.h > > @@ -8,6 +8,12 @@ > > #include > > #endif > > > > +#define mmio_read16be(addr) __raw_readw(addr) > > +#define mmio_read32be(addr) __raw_readl(addr) > > + > > +#define mmio_write16be(val, port) __raw_writew((val), (port)) > > +#define mmio_write32be(val, port) __raw_writel((val), (port)) > > + > > #include > > This looks correct to me, but there are two points that stick out to me: > > - why do you only do this for mmio and not for pio? > - why do you even use the generic_iomap wrappers rather than > the trivial asm-generic versions of those functions? > > Arnd At least i applied it and it works properly, dspi / dma drivers are back working. Thanks, Regards Angelo