From: Greg KH <gregkh@linuxfoundation.org>
To: Vandana BN <bnvandana@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lukas.bulwahn@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.
Date: Mon, 13 May 2019 10:42:17 +0200 [thread overview]
Message-ID: <20190513084217.GA17959@kroah.com> (raw)
In-Reply-To: <20190512234000.16555-2-bnvandana@gmail.com>
On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote:
> This patch resolves below errors reported by checkpatch
> ERROR: "(foo*)" should be "(foo *)"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo __init bar" should be "foo __init bar"
> ERROR: "foo __exit bar" should be "foo __exit bar"
>
> Signed-off-by: Vandana BN <bnvandana@gmail.com>
Better...
But your subject lines are almost all the same, with some being
identical to others, yet you are doing different things in each of the
patch.
So please provide a better subject line saying, in a unique way, exactly
what you are doing here.
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-13 8:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 19:38 [PATCH] Staging: kpc2000: kpc_dma: resolve checkpath errors and warnings Vandana BN
2019-05-10 20:34 ` [Linux-kernel-mentees] " Lukas Bulwahn
2019-05-12 15:48 ` Vandana BN
2019-05-11 6:04 ` Greg KH
2019-05-12 23:39 ` [PATCH v2 1/8] Staging: kpc2000: kpc_dma: resolve trailing whitespace error reported by checkpatch Vandana BN
2019-05-12 23:39 ` [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors " Vandana BN
2019-05-13 8:42 ` Greg KH [this message]
2019-05-13 10:43 ` Vandana BN
2019-05-12 23:39 ` [PATCH v2 3/8] " Vandana BN
2019-05-12 23:39 ` [PATCH v2 4/8] Staging: kpc2000: kpc_dma: Resolve code indent error " Vandana BN
2019-05-12 23:39 ` [PATCH v2 5/8] Staging: kpc2000: kpc_dma: Resolve coding style " Vandana BN
2019-05-12 23:39 ` [PATCH v2 6/8] Staging: kpc2000: kpc_dma: Resolve coding style warning " Vandana BN
2019-05-12 23:39 ` [PATCH v2 7/8] " Vandana BN
2019-05-12 23:40 ` [PATCH v2 8/8] " Vandana BN
2019-05-13 10:26 ` [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error " Vandana BN
2019-05-13 10:26 ` [PATCH v3 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations " Vandana BN
2019-05-13 10:26 ` [PATCH v3 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{','!' and open paranthesis '(' Vandana BN
2019-05-13 10:26 ` [PATCH v3 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch Vandana BN
2019-05-13 10:26 ` [PATCH v3 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line Vandana BN
2019-05-13 10:26 ` [PATCH v3 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented Vandana BN
2019-05-13 10:26 ` [PATCH v3 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch Vandana BN
2019-05-13 10:26 ` [PATCH v3 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation Vandana BN
2019-05-13 10:49 ` [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch Dan Carpenter
2019-05-13 12:00 ` Vandana BN
2019-05-13 13:43 ` [PATCH v4 " Vandana BN
2019-05-13 13:43 ` [PATCH v4 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations " Vandana BN
2019-05-13 13:43 ` [PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{','!' and open paranthesis '(' Vandana BN
2019-05-13 13:43 ` [PATCH v4 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch Vandana BN
2019-05-13 13:43 ` [PATCH v4 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line Vandana BN
2019-05-13 13:43 ` [PATCH v4 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented Vandana BN
2019-05-13 13:43 ` [PATCH v4 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch Vandana BN
2019-05-13 13:43 ` [PATCH v4 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation Vandana BN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513084217.GA17959@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bnvandana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox