From: Greg KH <gregkh@linuxfoundation.org>
To: Vatsala Narang <vatsalanarang@gmail.com>
Cc: devel@driverdev.osuosl.org, julia.lawall@lip6.fr,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
hadess@hadess.net
Subject: Re: [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.
Date: Mon, 13 May 2019 11:33:24 +0200 [thread overview]
Message-ID: <20190513093324.GA21213@kroah.com> (raw)
In-Reply-To: <20190505132253.4516-1-vatsalanarang@gmail.com>
On Sun, May 05, 2019 at 06:52:53PM +0530, Vatsala Narang wrote:
> Move logical operator to previous line to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 0b5bd047a552..b5e355de1199 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5656,9 +5656,9 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
> );
> #endif
>
> - if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta))
> - && sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta)
> - && sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
> + if ((sta_rx_data_pkts(psta) == sta_last_rx_data_pkts(psta)) &&
> + sta_rx_beacon_pkts(psta) == sta_last_rx_beacon_pkts(psta) &&
> + sta_rx_probersp_pkts(psta) == sta_last_rx_probersp_pkts(psta)
Odd, you should align these two lines, right?
> ) {
This should go on the previous line.
thanks,
greg k-h
prev parent reply other threads:[~2019-05-13 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 13:22 [PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line Vatsala Narang
2019-05-13 9:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513093324.GA21213@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox