From: Peter Zijlstra <peterz@infradead.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Pavankumar Kondeti <pkondeti@codeaurora.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Quentin Perret <quentin.perret@arm.com>
Subject: Re: [PATCH v2 4/7] sched: Add pelt_rq tracepoint
Date: Mon, 13 May 2019 14:14:45 +0200 [thread overview]
Message-ID: <20190513121445.GT2623@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190510113013.1193-5-qais.yousef@arm.com>
On Fri, May 10, 2019 at 12:30:10PM +0100, Qais Yousef wrote:
> +DECLARE_TRACE(pelt_rq,
> + TP_PROTO(int cpu, const char *path, struct sched_avg *avg),
> + TP_ARGS(cpu, path, avg));
> +
> +static __always_inline void sched_trace_pelt_cfs_rq(struct cfs_rq *cfs_rq)
> +{
> + if (trace_pelt_rq_enabled()) {
> + int cpu = cpu_of(rq_of(cfs_rq));
> + char path[SCHED_TP_PATH_LEN];
> +
> + cfs_rq_tg_path(cfs_rq, path, SCHED_TP_PATH_LEN);
> + trace_pelt_rq(cpu, path, &cfs_rq->avg);
> + }
> +}
> +
> +static __always_inline void sched_trace_pelt_rt_rq(struct rq *rq)
> +{
> + if (trace_pelt_rq_enabled()) {
> + int cpu = cpu_of(rq);
> +
> + trace_pelt_rq(cpu, NULL, &rq->avg_rt);
> + }
> +}
> +
> +static __always_inline void sched_trace_pelt_dl_rq(struct rq *rq)
> +{
> + if (trace_pelt_rq_enabled()) {
> + int cpu = cpu_of(rq);
> +
> + trace_pelt_rq(cpu, NULL, &rq->avg_dl);
> + }
> +}
Since it is only the one real tracepoint, how do we know which avg is
which?
next prev parent reply other threads:[~2019-05-13 12:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 11:30 [PATCH v2 0/7] Add new tracepoints required for EAS testing Qais Yousef
2019-05-10 11:30 ` [PATCH v2 1/7] sched: autogroup: Make autogroup_path() always available Qais Yousef
2019-05-10 11:30 ` [PATCH v2 2/7] sched: fair: move helper functions into fair.h Qais Yousef
2019-05-10 11:30 ` [PATCH v2 3/7] sched: fair.h: add a new cfs_rq_tg_path() Qais Yousef
2019-05-10 11:30 ` [PATCH v2 4/7] sched: Add pelt_rq tracepoint Qais Yousef
2019-05-13 12:14 ` Peter Zijlstra [this message]
2019-05-13 12:48 ` Qais Yousef
2019-05-13 13:37 ` Dietmar Eggemann
2019-05-10 11:30 ` [PATCH v2 5/7] sched: Add pelt_se tracepoint Qais Yousef
2019-05-10 11:30 ` [PATCH v2 6/7] sched: Add sched_overutilized tracepoint Qais Yousef
2019-05-13 12:08 ` Peter Zijlstra
2019-05-13 12:42 ` Qais Yousef
2019-05-10 11:30 ` [PATCH v2 7/7] sched: export the newly added tracepoints Qais Yousef
2019-05-13 12:28 ` [PATCH v2 0/7] Add new tracepoints required for EAS testing Peter Zijlstra
2019-05-13 13:42 ` Qais Yousef
2019-05-13 15:06 ` Peter Zijlstra
2019-05-13 15:18 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513121445.GT2623@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pkondeti@codeaurora.org \
--cc=qais.yousef@arm.com \
--cc=quentin.perret@arm.com \
--cc=rostedt@goodmis.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox