From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29675C04AAA for ; Mon, 13 May 2019 18:21:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E49B22085A for ; Mon, 13 May 2019 18:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557771704; bh=MtllVAmbTfrkUWUpJJ0qEVSO43Trwl7l2UmsRn/Xs7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=aRvGa0h+lYSWE5OE07yLCym4AAnUjlTZmy8xULwRi/pn8ZEevAdTAUQmdKqL878pe O6vzo/xm1dTmDGK4h9tYmhgWy0yiAhjbaxroLQqrtHtlgNQKk8shO1auyuPawNvNDx KTzJIriDWRMBPyxy8CFOSJ/AsIho2D/m1BKkov8E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbfEMSVl (ORCPT ); Mon, 13 May 2019 14:21:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:10239 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfEMSVl (ORCPT ); Mon, 13 May 2019 14:21:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:21:40 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga007.jf.intel.com with ESMTP; 13 May 2019 11:21:40 -0700 Date: Mon, 13 May 2019 12:16:18 -0600 From: Keith Busch To: Kai-Heng Feng Cc: sagi@grimberg.me, rafael@kernel.org, linux-pm@vger.kernel.org, Mario.Limonciello@dell.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, Christoph Hellwig Subject: Re: [PATCH] nvme/pci: Use host managed power state for suspend Message-ID: <20190513181618.GD15437@localhost.localdomain> References: <20190510212937.11661-1-keith.busch@intel.com> <0080aaff18e5445dabca509d4113eca8@AUSX13MPC105.AMER.DELL.COM> <955722d8fc16425dbba0698c4806f8fd@AUSX13MPC105.AMER.DELL.COM> <20190513143754.GE15318@localhost.localdomain> <7ab8274ef1ce46fcae54a50abc76ae4a@AUSX13MPC105.AMER.DELL.COM> <20190513145708.GA25897@lst.de> <20190513151652.GB15437@localhost.localdomain> <9AE4A3E7-CDB8-4730-8B4E-43C93FC0C47F@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9AE4A3E7-CDB8-4730-8B4E-43C93FC0C47F@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 14, 2019 at 01:16:22AM +0800, Kai-Heng Feng wrote: > Disabling HMB prior suspend makes my original patch work without memory > barrier. > > However, using the same trick on this patch still freezes the system during > S2I. Could you post your code, please?