From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F327C04AA7 for ; Mon, 13 May 2019 20:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C3DF217F5 for ; Mon, 13 May 2019 20:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557778364; bh=WCUFh+woPhcJEK6e8moOGrzwENC0TrzGg0GLcBimDv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JW0Qn6A2jdYpE5MFIz4pJpTz83nUH5HDEaMl+e4MzMr5u+Ej+8Vet5rgyYTyV5HDY B8+kXOjxIyElILRxE2dex1xCp1h4gIyI7M8cpUM/3cOs5nPQjqGvlWuwMFbGBfQ9hA Qr/kN9XYDbNMiGBFTtyXg7sg1muKXfiWWu4wijQE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726349AbfEMUMm (ORCPT ); Mon, 13 May 2019 16:12:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:37990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbfEMUMl (ORCPT ); Mon, 13 May 2019 16:12:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AAD22085A; Mon, 13 May 2019 20:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557778360; bh=WCUFh+woPhcJEK6e8moOGrzwENC0TrzGg0GLcBimDv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0z6teznxoJKK51aNl9f25UfLlJqBuG+fqDz9q1N+bcHuTieX9gqac12jWJZX1kX1Q kErrK5M8ptjrdBlZ0QWRonzYfS6/f6IT41vHfilgl6t1xeFwR/L7d2bCYojfQw8HTl V8SrCeK+7M1XF9cJzPyEkbAInQvPqGv1TJ1B0e1U= Date: Mon, 13 May 2019 22:12:35 +0200 From: Greg KH To: Raul E Rangel Cc: stable@vger.kernel.org, linux-mmc@vger.kernel.org, djkurtz@google.com, adrian.hunter@intel.com, zwisler@chromium.org, Linus Walleij , linux-kernel@vger.kernel.org, Ulf Hansson Subject: Re: [stable/4.14.y PATCH 2/3] mmc: Fix null pointer dereference in mmc_init_request Message-ID: <20190513201235.GB17404@kroah.com> References: <20190513175521.84955-1-rrangel@chromium.org> <20190513175521.84955-3-rrangel@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190513175521.84955-3-rrangel@chromium.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 13, 2019 at 11:55:20AM -0600, Raul E Rangel wrote: > It is possible for queuedata to be cleared in mmc_cleanup_queue before > the request has been started. This will result in dereferencing a null > pointer. > > Signed-off-by: Raul E Rangel > --- > > drivers/mmc/core/queue.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.