From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736B4C04AB4 for ; Tue, 14 May 2019 18:12:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A813216B7 for ; Tue, 14 May 2019 18:12:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Do+8Q+pH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727581AbfENSMl (ORCPT ); Tue, 14 May 2019 14:12:41 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38827 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727547AbfENSMk (ORCPT ); Tue, 14 May 2019 14:12:40 -0400 Received: by mail-pf1-f196.google.com with SMTP id b76so1123385pfb.5 for ; Tue, 14 May 2019 11:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=N4UQ8E37RD8PM/SrG8N/O0bEDGjz00r1+gSc2WyT1f4=; b=Do+8Q+pHF8OB+tlzSEbCAlPOY5hObzGGmcvPm0YH3pOm8OWb+2EG6k/+3FX9ODnKET HeeejJJzGaiMQRAOmVbGKQQo9GMUp77yZaFJ+oq5A5++UZ2bqGz1eozejMrClIviWLaH 6NqHaVQChwYnFjxvjCGyJrQCTbtCzP1YDVjWmeDvwiekfu/CIsr1rAo7eeV2cOghCM3s jg1XfDoXavpa+8h5sP6zhUgTkyTdA3gv3smrtEjkWIEZtUEMHzNqwHjzR4ACtYGyLA5t PjdZhQFtOg524SURCKg00duz4q2SfEaie9Z/aI0bjh6oNPjygJN8c7oYJhw88kmkUhL7 hq9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=N4UQ8E37RD8PM/SrG8N/O0bEDGjz00r1+gSc2WyT1f4=; b=hQpOMyB24B1fFUHM4aokvqfSY6w59a4Wt3uDsECZwjATL+JCwDIMsqA4fH6DQ/Rj7U bH88Cm7W/gg5BdVJm3sWE1uV3oLrZzvidGfF1Vxcz2ugCSdKxv00mpSqA650d/+kX51Z TN7U+aBHObh5p6l2JAS59ImabJXvfinaxPIMgeGCZ7SXeQea/Pvn+dwMjrg6el4vVxnT v/RbtUxgjVtp+ZpRySApAW/P/jjzHmxW8x9fEiQGeOXkK+JU1ptfplukr47ImTTFh7Vy leIdpdg9Glh3JzSDvCuEAvF9hA/qd/YpuLfu/l6NPitw23tXEx1Zt8lgNdkYojm2wq5Q srbw== X-Gm-Message-State: APjAAAUAVOw7aUc90DZbXvxFBcCWs/cMb869OCavnz1PyLNrBfWH3XG4 9pb/9ErvecieC418JwJ5Zf+NaA== X-Google-Smtp-Source: APXvYqzF1W3MvAqglRw1f3U3GzCogO4oDzfR+rvBgcAvxH3aiWBoZY2un6t4j9IVvIzAxmzzun0V4w== X-Received: by 2002:a62:d244:: with SMTP id c65mr3681839pfg.173.1557857559066; Tue, 14 May 2019 11:12:39 -0700 (PDT) Received: from google.com ([2620:15c:2cd:2:d714:29b4:a56b:b23b]) by smtp.gmail.com with ESMTPSA id w189sm22611956pfw.147.2019.05.14.11.12.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 14 May 2019 11:12:38 -0700 (PDT) Date: Tue, 14 May 2019 11:12:33 -0700 From: Brendan Higgins To: Peter Zijlstra Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com, Josh Poimboeuf , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, kbuild test robot Subject: Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list Message-ID: <20190514181233.GB109557@google.com> References: <20190514054251.186196-1-brendanhiggins@google.com> <20190514054251.186196-9-brendanhiggins@google.com> <20190514065643.GC2589@hirez.programming.kicks-ass.net> <20190514081223.GA230665@google.com> <20190514084655.GK2589@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote: > On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote: > > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote: > > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote: > > > > This fixes the following warning seen on GCC 7.3: > > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > > > > > > > > > What is that file and function; no kernel tree near me seems to have > > > that. > > > > Oh, sorry about that. The function is added in the following patch, > > "[PATCH v3 09/18] kunit: test: add support for test abort"[1]. > > > > My apologies if this patch is supposed to come after it in sequence, but > > I assumed it should come before otherwise objtool would complain about > > the symbol when it is introduced. > > Or send me all patches such that I have context, or have a sane > Changelog that gives me context. Just don't give me one patch with a > crappy changelog. I will provide more context in the next revision. Sorry about that!