Re: [PATCH 2/5] drm/bridge/synopsys: dw-hdmi: Add "unwedge" for ddc bus

Doug Anderson
2019-05-15T18:36:50Z

Hi,

On Wed, May 15, 2019 at 11:20 AM Sean Paul <sean@poorly.run> wrote:

> > + if (IS_ERR(hdmi->default_state) &&
> > + !IS_ERR(hdmi->unwedge_state)) {
> > + dev_warn(dev,
> > + "Unwedge requires default pinctrl\n");
>
> Can you downgrade this message to info or dbg? Given how rare this issue is, we
> probably don't want to spam everyone who is happily using dw-hdmi.

I don't think it will spam anyone, will it? It will only spam if you
_do_ specify an unwedge state and you _don't_ specify a default state.
This seems like something you'd want a pretty serious warning about
because it meant that you wanted to use unwedge but you didn't specify
it properly.

> Reviewed-by: Sean Paul <sean@poorly.run>

Thanks!

-Doug