From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B06EC04E53 for ; Wed, 15 May 2019 12:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 126C22082E for ; Wed, 15 May 2019 12:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557922776; bh=W25fDk90CE/VcUeJCvl3ivWPtFGrBDi6Fs+1ehglUec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GGH6UJaISc6/klLV6gQlY45KakFJpjTmJaslsBLjYWRQzbFB2D+4DQGbwFupO0hkv yPkPAf9UBN+VorN9lL/P+p03sxUgKslyZORfWosfOcgcasJd6BQ44pq9eVy+lV3fcu OA2+CP9ffIRF+MXiI5tnBLVgKCErrcfFrHdp2TDg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727451AbfEOLAc (ORCPT ); Wed, 15 May 2019 07:00:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:57190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726896AbfEOLAW (ORCPT ); Wed, 15 May 2019 07:00:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C51C21743; Wed, 15 May 2019 11:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918022; bh=W25fDk90CE/VcUeJCvl3ivWPtFGrBDi6Fs+1ehglUec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c6zrp7vxIvQB5s0KkEoz1hf7Oes2kJ5Ma1lOSE6Aaqo6pJ2pYdbTjsvtpFkPbytp2 HXoLjjCwwuTUf26jcHbYM95gIU8ssPwlsII5sEkE2dnQMj5TMuXFKlKrDD4gNXR2Aq KRaEjoFV8gCL4K6+oj9dywiEYUIMvxW/w8P/jeBs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mukesh Ojha , "Sasha Levin (Microsoft)" Subject: [PATCH 3.18 23/86] usb: u132-hcd: fix resource leak Date: Wed, 15 May 2019 12:55:00 +0200 Message-Id: <20190515090647.685523125@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090642.339346723@linuxfoundation.org> References: <20190515090642.339346723@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit f276e002793cdb820862e8ea8f76769d56bba575 ] if platform_driver_register fails, cleanup the allocated resource gracefully. Signed-off-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (Microsoft) --- drivers/usb/host/u132-hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index ab5128755672..3d9ce725d1df 100644 --- a/drivers/usb/host/u132-hcd.c +++ b/drivers/usb/host/u132-hcd.c @@ -3234,6 +3234,9 @@ static int __init u132_hcd_init(void) printk(KERN_INFO "driver %s\n", hcd_name); workqueue = create_singlethread_workqueue("u132"); retval = platform_driver_register(&u132_platform_driver); + if (retval) + destroy_workqueue(workqueue); + return retval; } -- 2.19.1