From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0464C04E87 for ; Wed, 15 May 2019 11:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B2220881 for ; Wed, 15 May 2019 11:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919688; bh=tAJLvgn80sM2ITNXEPXKr5Bol/t4yxuXu6QpLrl1kgA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lC9hNfZnwUWRpEuKQE7MKYFMs3JTZsVk7h2FEylc9uSUdRnMHMFVBlX3j5XnkXi4S mU22tJWZ1XkzHLXKp5oycdONMOKgR8/MudnnidYcE9OVDOLZ2JlbjrzpwUou45P0JZ lNcUYp0ecRcpy9kOBfUgQQqVm4yTAZ25xO9wqXuw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732342AbfEOL2G (ORCPT ); Wed, 15 May 2019 07:28:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:39012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732319AbfEOL2E (ORCPT ); Wed, 15 May 2019 07:28:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE71B20818; Wed, 15 May 2019 11:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919683; bh=tAJLvgn80sM2ITNXEPXKr5Bol/t4yxuXu6QpLrl1kgA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kSou2LmcaKepsxqlLEb1q5vDLSle+tB3hemRRcbOrTVaFey4n+x/u6ZmjrBaqYBNv K+Yo8pD/87Hmg/VTnrsNLC8yrclFq/F85hfsHYt2xCaKcEKtp5TBUpS0tNm9W/z2t6 WdQq6BOrO18pmCYXxV1BZKAAsD3mjQZoeHBwEqXk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bastian Beischer , Jiri Olsa , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Peter Zijlstra , Sasha Levin Subject: [PATCH 5.0 054/137] perf top: Always sample time to satisfy needs of use of ordered queuing Date: Wed, 15 May 2019 12:55:35 +0200 Message-Id: <20190515090657.421154128@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090651.633556783@linuxfoundation.org> References: <20190515090651.633556783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 1e6db2ee86e6a4399fc0ae5689e55e0fd1c43caf ] Bastian reported broken 'perf top -p PID' command, it won't display any data. The problem is that for -p option we monitor single thread, so we don't enable time in samples, because it's not needed. However since commit 16c66bc167cc we use ordered queues to stash data plus later commits added logic for dropping samples in case there's big load and we don't keep up. All this needs timestamp for sample. Enabling it unconditionally for perf top. Reported-by: Bastian Beischer Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Peter Zijlstra Cc: bastian beischer Fixes: 16c66bc167cc ("perf top: Add processing thread") Link: http://lkml.kernel.org/r/20190415125333.27160-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/builtin-top.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 616408251e258..63750a711123f 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1393,6 +1393,7 @@ int cmd_top(int argc, const char **argv) * */ .overwrite = 0, .sample_time = true, + .sample_time_set = true, }, .max_stack = sysctl__max_stack(), .annotation_opts = annotation__default_options, -- 2.20.1