From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBFDC04E53 for ; Wed, 15 May 2019 11:23:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61EF820862 for ; Wed, 15 May 2019 11:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919412; bh=tgkD4hdVNYfmGU8kBXy6K9TdVHq1FpxTKLU/f6FbWjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lylktK9W0Y5XNfBj4NdJP6dajf4sZueS2DT8UvCR6d/mW7IF6vqG4oG4VCLZ10aBl J0I1/zecRY9Cl9VsmG03ZgPvW90pUw3cyIGAe6kgDiX2cBuWmyYAmtNMaX2tySzbhG zYjdQV/hQvWUuvdHueYscKg2zGnVmdvfDH2Tf/0k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731658AbfEOLXb (ORCPT ); Wed, 15 May 2019 07:23:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:33882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731383AbfEOLX3 (ORCPT ); Wed, 15 May 2019 07:23:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A616E216FD; Wed, 15 May 2019 11:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919409; bh=tgkD4hdVNYfmGU8kBXy6K9TdVHq1FpxTKLU/f6FbWjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YUCV5rLg1QJbFU4MeZRrDshEEnp/PCmWNkRIZTQ3qCCUECEw3L4RvtQDCvxtCJsEV EZtdgskP1+hu35NnxjKpezsja9SxRO1bfGCmuSL7tMtYpyhWoJmcB2SwdWjsoVBZVu DNhbMSl8xwCURW22PUmJxJmgRZOObDNJQVNUP8GA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Hildenbrand , Oscar Salvador , Wei Yang , Michal Hocko , Pankaj Gupta , Pavel Tatashin , Qian Cai , Arun KS , Mathieu Malaterre , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.19 064/113] mm/memory_hotplug.c: drop memory device reference after find_memory_block() Date: Wed, 15 May 2019 12:55:55 +0200 Message-Id: <20190515090658.411439340@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090652.640988966@linuxfoundation.org> References: <20190515090652.640988966@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 89c02e69fc5245f8a2f34b58b42d43a737af1a5e ] Right now we are using find_memory_block() to get the node id for the pfn range to online. We are missing to drop a reference to the memory block device. While the device still gets unregistered via device_unregister(), resulting in no user visible problem, the device is never released via device_release(), resulting in a memory leak. Fix that by properly using a put_device(). Link: http://lkml.kernel.org/r/20190411110955.1430-1-david@redhat.com Fixes: d0dc12e86b31 ("mm/memory_hotplug: optimize memory hotplug") Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador Reviewed-by: Wei Yang Acked-by: Michal Hocko Acked-by: Pankaj Gupta Cc: David Hildenbrand Cc: Pavel Tatashin Cc: Qian Cai Cc: Arun KS Cc: Mathieu Malaterre Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- mm/memory_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 156991edec2a8..af67355622159 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -901,6 +901,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ */ mem = find_memory_block(__pfn_to_section(pfn)); nid = mem->nid; + put_device(&mem->dev); /* associate pfn range with the zone */ zone = move_pfn_range(online_type, nid, pfn, nr_pages); -- 2.20.1