From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1401BC04E53 for ; Wed, 15 May 2019 12:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D029820657 for ; Wed, 15 May 2019 12:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727667AbfEOMJL convert rfc822-to-8bit (ORCPT ); Wed, 15 May 2019 08:09:11 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:49093 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729362AbfEOMJJ (ORCPT ); Wed, 15 May 2019 08:09:09 -0400 X-Originating-IP: 77.136.197.83 Received: from xps13 (83.197.136.77.rev.sfr.net [77.136.197.83]) (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 981291C0013; Wed, 15 May 2019 12:08:59 +0000 (UTC) Date: Wed, 15 May 2019 14:08:58 +0200 From: Miquel Raynal To: masonccyang@mxic.com.tw Cc: bbrezillon@kernel.org, broonie@kernel.org, christophe.kerello@st.com, computersforpeace@gmail.com, devicetree@vger.kernel.org, dwmw2@infradead.org, geert@linux-m68k.org, juliensu@mxic.com.tw, lee.jones@linaro.org, liang.yang@amlogic.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, marcel.ziswiler@toradex.com, marek.vasut@gmail.com, mark.rutland@arm.com, paul.burton@mips.com, richard@nod.at, robh+dt@kernel.org, stefan@agner.ch, zhengxunli@mxic.com.tw Subject: Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller Message-ID: <20190515140858.77213af9@xps13> In-Reply-To: References: <1555320234-15802-1-git-send-email-masonccyang@mxic.com.tw> <1555320234-15802-3-git-send-email-masonccyang@mxic.com.tw> <20190512151820.4f2dd9da@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi masonccyang@mxic.com.tw, masonccyang@mxic.com.tw wrote on Wed, 15 May 2019 16:48:46 +0800: > Hi Miquel, > > > > +// SPDX-License-Identifier: GPL-2.0 > > > +// > > > +// Copyright (C) 2019 Macronix International Co., Ltd. > > > +// > > > +// Authors: > > > +// Mason Yang > > > +// zhengxunli > > > > This is not a valid name. > > > > Also if he appears here I suppose he should be credited in the > > module_authors() macro too. > > I think Li should maintain this NAND driver later, This entry is for the authors of the driver. If he will maintain the driver, then add a new entry in MAINTAINERS. > > > +} > > > + > > > +static const struct nand_controller_ops mxic_nand_controller_ops = { > > > + .exec_op = mxic_nand_exec_op, > > > +}; > > > + > > > +static int mx25f0a_nand_probe(struct platform_device *pdev) > > > +{ > > > + struct mtd_info *mtd; > > > + struct mx25f0a_mfd *mfd = dev_get_drvdata(pdev->dev.parent); > > > + struct mxic_nand_ctlr *mxic; > > > + struct nand_chip *nand_chip; > > > + int err; > > > + > > > + mxic = devm_kzalloc(&pdev->dev, sizeof(struct mxic_nand_ctlr), > > > + GFP_KERNEL); > > > > mxic for a NAND controller structure is probably not a name meaningful > > enough. > > How about *fmc or *mxic_fmc ? fmc is fine, even if I personally prefer nfc for NAND flash controller. Here the 'm' in fmc stands for 'memory' but I am not sure if the controller can manage something else than NAND flash anyway? Thanks, Miquèl