From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: acme@redhat.com, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, john.garry@huawei.com,
wanghaibin.wang@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf jevents: Remove unused variables
Date: Wed, 15 May 2019 16:12:07 -0300 [thread overview]
Message-ID: <20190515191207.GC23162@kernel.org> (raw)
In-Reply-To: <1557919169-23972-1-git-send-email-yuzenghui@huawei.com>
Em Wed, May 15, 2019 at 11:19:29AM +0000, Zenghui Yu escreveu:
> Fix gcc warning:
s/Fix/Address/g
Thanks, applied.
- Arnaldo
> pmu-events/jevents.c: In function ‘save_arch_std_events’:
> pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]
> struct stat *sb = data;
> ^~
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> tools/perf/pmu-events/jevents.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 68c92bb..92e60fd 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -414,7 +414,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
> char *metric_name, char *metric_group)
> {
> struct event_struct *es;
> - struct stat *sb = data;
>
> es = malloc(sizeof(*es));
> if (!es)
> --
> 1.8.3.1
>
--
- Arnaldo
next prev parent reply other threads:[~2019-05-15 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 11:19 [PATCH] perf jevents: Remove unused variables Zenghui Yu
2019-05-15 19:12 ` Arnaldo Carvalho de Melo [this message]
2019-05-18 9:27 ` [tip:perf/core] perf jevents: Remove unused variable tip-bot for Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515191207.GC23162@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox