Re: [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC

Doug Anderson
2019-05-15T18:30:29Z

Hi,

On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke <mka@chromium.org> wrote:

> Raise the temperature of the GPU thermal trip point for speedy
> to 80°C. This is the value used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for speedy.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> index 2ac8748a3a0c..394a9648faee 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> @@ -64,6 +64,10 @@
> temperature = <70000>;
> };
>
> +&gpu_alert0 {
> + temperature = <80000>;
> +};
> +
> &edp {

Similar comments to patch set #1 about sort ordering.

...I'll also notice that if we do end up setting the "critical" to 100
C for most of veyron then I guess we'll have to switch it back to 90 C
here for speedy to match downstream? Maybe that's an argument for
doing it in this patchset so we don't forget? I'm somewhat amazed
that downstream has only 10 C between "alert" and 'critical" for GPU
for speedy, but I guess it's OK?

-Doug