From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7797C04AAF for ; Thu, 16 May 2019 16:11:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 788F2206BF for ; Thu, 16 May 2019 16:11:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbfEPQLf (ORCPT ); Thu, 16 May 2019 12:11:35 -0400 Received: from mga04.intel.com ([192.55.52.120]:25261 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfEPQLf (ORCPT ); Thu, 16 May 2019 12:11:35 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 09:11:34 -0700 X-ExtLoop1: 1 Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga007.jf.intel.com with ESMTP; 16 May 2019 09:11:34 -0700 Date: Thu, 16 May 2019 09:14:29 -0700 From: Jacob Pan To: Jean-Philippe Brucker Cc: iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Eric Auger , Alex Williamson , "Tian, Kevin" , Raj Ashok , Andriy Shevchenko , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v3 09/16] iommu: Introduce guest PASID bind function Message-ID: <20190516091429.6d06f7e1@jacob-builder> In-Reply-To: References: <1556922737-76313-1-git-send-email-jacob.jun.pan@linux.intel.com> <1556922737-76313-10-git-send-email-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 May 2019 15:14:40 +0100 Jean-Philippe Brucker wrote: > Hi Jacob, > > On 03/05/2019 23:32, Jacob Pan wrote: > > +/** > > + * struct gpasid_bind_data - Information about device and guest > > PASID binding > > + * @gcr3: Guest CR3 value from guest mm > > + * @pasid: Process address space ID used for the guest mm > > + * @addr_width: Guest address width. Paging mode can also > > be derived. > > + */ > > +struct gpasid_bind_data { > > + __u64 gcr3; > > + __u32 pasid; > > + __u32 addr_width; > > + __u32 flags; > > +#define IOMMU_SVA_GPASID_SRE BIT(0) /* supervisor > > request */ > > + __u8 padding[4]; > > +}; > > Could you wrap this structure into a generic one like we now do for > bind_pasid_table? It would make the API easier to extend, because if > we ever add individual PASID bind on Arm (something I'd like to do for > virtio-iommu, eventually) it will have different parameters, as our > PASID table entry has a lot of fields describing the page table > format. > > Maybe something like the following would do? > > struct gpasid_bind_data { > #define IOMMU_GPASID_BIND_VERSION_1 1 > __u32 version; > #define IOMMU_GPASID_BIND_FORMAT_INTEL_VTD 1 > __u32 format; > union { > // the current gpasid_bind_data: > struct gpasid_bind_intel_vtd vtd; > }; > }; > OK, sounds great.