From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371DEC04AAF for ; Fri, 17 May 2019 02:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01F1120848 for ; Fri, 17 May 2019 02:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558059094; bh=L9gJDk5SmlO1Bjp81hnl855ONnNEMGWCYhhypjgHXmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GJYbds6F8kA+vHmMv5PlxeLWYZfxtnerXmDHku8IcbEHrbOR97utJNGt0YlOFuYUb mk1gABUtgu/BFbs26Q2vZYLZMvYQKUurNuoa1oIrI4Ud2wA50ckR9MtCT/iuebsBEv ZiiUar4x29f21E67FENh8HPiuOrmeYq7cR2Ixw5Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbfEQCLd (ORCPT ); Thu, 16 May 2019 22:11:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:43978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726703AbfEQCLc (ORCPT ); Thu, 16 May 2019 22:11:32 -0400 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 068752082E; Fri, 17 May 2019 02:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558059092; bh=L9gJDk5SmlO1Bjp81hnl855ONnNEMGWCYhhypjgHXmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fAz0fNHe5dnd4aoxP7ra/g7ObfoBZi3UgnTGjMsqpI0M0LkM+Xvra0hBSlbhPnmT1 FcWJ/7iih/uZiogrwPeZOE2V0cr1ZYDgC1igYQ99sgmeG6hTJtmMb1rMjN7cts0lmm FE/4qhHUBZO/XJoqg4UfiOIaTb5BI+Vdmlc/1DQc= Date: Fri, 17 May 2019 10:10:51 +0800 From: Shawn Guo To: Ran Wang Cc: Leo Li , Rob Herring , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] arm64: dts: ls1028a: Add USB dt nodes Message-ID: <20190517021050.GW15856@dragon> References: <20190508064814.14223-1-ran.wang_1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190508064814.14223-1-ran.wang_1@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 08, 2019 at 06:46:37AM +0000, Ran Wang wrote: > This patch adds USB dt nodes for LS1028A. > > Signed-off-by: Ran Wang > --- > Changes in v3: > - Add space between label and node name. > - Add spcae with properties and '='. > - Add SoC specific compatible. > > Changes in v2: > - Rename node from usb3@... to usb@... to meet DTSpec > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 8dd3501..19519df 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -144,6 +144,26 @@ > clocks = <&sysclk>; > }; > > + usb0: usb@3100000 { Please sort the nodes with unit-address in the address. That said, it should go after watchdog@23c0000. > + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; interrupts = ; Shawn > + dr_mode = "host"; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + }; > + > + usb1: usb@3110000 { > + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; > + dr_mode = "host"; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + }; > + > i2c0: i2c@2000000 { > compatible = "fsl,vf610-i2c"; > #address-cells = <1>; > -- > 1.7.1 >