From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DD0C04AB4 for ; Fri, 17 May 2019 07:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6610A20868 for ; Fri, 17 May 2019 07:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558078317; bh=W80f0Osmfp2T/2G+HffeiwRgi9eEG28g8hfA/rYHfV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IrnvHvlY1dObR3fI5Un9ZUao/ExsLAXmFHVs2itGGELgAEiyS6QPNqMbkRp47ajmt kTaX1GBwAjIkWbqTQGpImF2Xsp+RNuN8YyEoCJhsRtHnn47t1JW1tl3q4anLIqZzkX iuQFTOulJw0CygbJfYUJaTBAmHxwbQiqviTkQA4k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728324AbfEQHb4 (ORCPT ); Fri, 17 May 2019 03:31:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:43968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbfEQHb4 (ORCPT ); Fri, 17 May 2019 03:31:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16BD1206A3; Fri, 17 May 2019 07:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558078315; bh=W80f0Osmfp2T/2G+HffeiwRgi9eEG28g8hfA/rYHfV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AnTZv7Gdtfl8lB37+XTgoUosol4ItZo2FUfZvDbTGqk5YeTBuIkBW8dUAceharY+n fqfW/TGAG14Qm9b4DL7/k7AMS4IbfG/Ycqovq0BgJr5RdLr1vNk7P2ckTPLTOgQWXj 0M0P1EtYNk6hUfSEEAiXPyrusp6rBGFtqBSvRAZk= Date: Fri, 17 May 2019 09:31:53 +0200 From: Greg Kroah-Hartman To: Quentin Deslandes Cc: "kernel-janitors@vger.kernel.org" , "devel@driverdev.osuosl.org" , Mukesh Ojha , "linux-kernel@vger.kernel.org" , Forest Bond , Ojaswin Mujoo Subject: Re: [PATCH v2] staging: vt6656: returns error code on vnt_int_start_interrupt fail Message-ID: <20190517073153.GA4776@kroah.com> References: <20190516093046.1400-1-quentin.deslandes@itdev.co.uk> <20190516115653.15120-1-quentin.deslandes@itdev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516115653.15120-1-quentin.deslandes@itdev.co.uk> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 16, 2019 at 11:57:15AM +0000, Quentin Deslandes wrote: > Returns error code from 'vnt_int_start_interrupt()' so the device's private > buffers will be correctly freed and 'struct ieee80211_hw' start function > will return an error code. > > Signed-off-by: Quentin Deslandes > --- > drivers/staging/vt6656/int.c | 4 +++- > drivers/staging/vt6656/int.h | 2 +- > drivers/staging/vt6656/main_usb.c | 12 +++++++++--- > 3 files changed, 13 insertions(+), 5 deletions(-) What changed from v1? Always put that below the --- line. Please fix up and resend a v3. thanks, greg k-h