From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15AAC04AB4 for ; Fri, 17 May 2019 09:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 930EC20879 for ; Fri, 17 May 2019 09:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558086497; bh=UI5UD2PNyH/H3Zr/rvoQcZgX0FuVQLH05Y88u0Zl+js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=06vjHhPAqwGi81+vQyiTIOm8oUjsjMrFkim65x2FQKKqZwC39kie8GAuqruNPWi82 6ZIxQkF3qhAI53O18OyjEMQHIxQxtxYDU6zmlOWPLss3bGlG8pBZaqygEsmNQAd0w4 oK+R/4oyefeT8l+BCAxPPE5WH9R5gNIHU27CdiYQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbfEQJsQ (ORCPT ); Fri, 17 May 2019 05:48:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:33484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727309AbfEQJsQ (ORCPT ); Fri, 17 May 2019 05:48:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D690E20833; Fri, 17 May 2019 09:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558086495; bh=UI5UD2PNyH/H3Zr/rvoQcZgX0FuVQLH05Y88u0Zl+js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xuVhqFcHGVRenIW8vohc3Iz1ogZGNJztTJv6jXFlipKzZODdHHX7NzvZQc/43bUx4 NY3Bjhc7bN3dmr7EJXduuC+E/4AGQacFqp6l6yMUltEq5r6keDO/UcqOn+4Fktq9G+ v46LeGBzicgzYH7AIsYRADcF+s01QGbkZ4DYcYYs= Date: Fri, 17 May 2019 11:48:13 +0200 From: Greg KH To: Miguel Ojeda Cc: Peter Zijlstra , Ivan Babrou , Josh Poimboeuf , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel , Linux Kbuild mailing list , kernel-team Subject: Re: Linux 4.19 and GCC 9 Message-ID: <20190517094813.GA15090@kroah.com> References: <20190516225013.nvhwqi5tfwtby6qb@treble> <20190517050931.GB32367@kroah.com> <20190517073813.GB2589@hirez.programming.kicks-ass.net> <20190517085126.GA3249@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > On Fri, May 17, 2019 at 10:51 AM Greg KH wrote: > > > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra wrote: > > > > > > > > Right; if there is anything you can reproduce on linus.git I'll happily > > > > have a look. If it doesn't reproduce all you have to do is find the > > > > patches that make it work and ask Greg. > > > > > > Just to clarify: Linus' master is clean of these issues with GCC 9.1.1. > > > > Great! Care to find the patches that did that work and send me the git > > commit ids so that I can queue them up? I don't have gcc9 here yet on > > my systems, so I can not test for this. > > I am unsure about the perf and the objtools parts (Peter/Josh?), but > about the -Wmissing-attributes I cleaned, they were these: > > a6e60d84989f ("include/linux/module.h: copy __init/__exit attrs to > init/cleanup_module") > c0d9782f5b6d ("Compiler Attributes: add support for __copy (gcc >= 9)") > ff98e20ef208 ("lib/crc32.c: mark crc32_le_base/__crc32c_le_base > aliases as __pure") This last patch is not needed, as that only resolves something that showed in in 4.20. thanks, greg k-h