From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F6CDC04AB4 for ; Fri, 17 May 2019 23:12:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C65A2166E for ; Fri, 17 May 2019 23:12:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="Vn3yfw/j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728520AbfEQXMO (ORCPT ); Fri, 17 May 2019 19:12:14 -0400 Received: from onstation.org ([52.200.56.107]:37476 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726757AbfEQXMN (ORCPT ); Fri, 17 May 2019 19:12:13 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 3FFDD3E957; Fri, 17 May 2019 23:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1558134732; bh=qurT+nMJYRUKyNSe+yc/AIUY3mDFS6CFIis415+foE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vn3yfw/jnNsapohuXlzskfz4gwwlrmCgVVz8/V0C5xRjhJeelhjjMS8DOJz6y8PrD vi0aLVvEPz3Z3VRqtNHt4NOdaT+jhb9Pztk4fbqWTEXlFP6I1vJbUEokYc2OcI4sVJ dTotabBBmQRVlsZ/lNKCKXuaEnJKll0PjE8fwsis= Date: Fri, 17 May 2019 19:12:11 -0400 From: Brian Masney To: Rob Herring Cc: Lee Jones , Daniel Thompson , Jingoo Han , Jacek Anaszewski , Pavel Machek , Mark Rutland , Bartlomiej Zolnierkiewicz , dri-devel , Linux LED Subsystem , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux Fbdev development list , Dan Murphy , Jonathan Marek Subject: Re: [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings Message-ID: <20190517231211.GA7907@basecamp> References: <20190424092505.6578-1-masneyb@onstation.org> <20190424092505.6578-3-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Fri, May 17, 2019 at 04:11:48PM -0500, Rob Herring wrote: > On Wed, Apr 24, 2019 at 4:25 AM Brian Masney wrote: > > > > Add new backlight bindings for the TI LM3630A dual-string white LED. > > > > Signed-off-by: Brian Masney > > Reviewed-by: Rob Herring > > --- > > Changes since v5: > > - Change 'lm3630a_bl@38' in examples to 'led-controller@38' > > > > Changes since v4: > > - Drop $ref from led-sources > > - Drop description from reg of i2c address > > - Expand description of reg for the control bank > > - Drop status from examples > > > > Changes since v3: > > - Add label. I didn't add a description for it since that'll come from > > the common properties once its converted. > > > > Changes since v2: > > - Update description of max-brightness > > - Add description for reg > > - Correct typo: s/tranisiton/transition > > - add reg to control banks > > - add additionalProperties > > > > .../leds/backlight/lm3630a-backlight.yaml | 129 ++++++++++++++++++ > > 1 file changed, 129 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > > I'm working on getting the examples to be validated by the schema (in > addition to just building with dtc) and there's a couple of errors: > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > '#address-cells', '#size-cells' do not match any of the regexes: > '^led@[01]$', 'pinctrl-[0-9]+' > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > '#address-cells', '#size-cells' do not match any of the regexes: > '^led@[01]$', 'pinctrl-[0-9]+' > > You didn't list '#address-cells' and '#size-cells'. > > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > led@0: 'ti,linear-mapping-mode' does not match any of the regexes: > 'pinctrl-[0-9]+' > Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: > led@1: 'ti,linear-mapping-mode' does not match any of the regexes: > 'pinctrl-[0-9]+' > > 'ti,linear-mapping-mode' is not defined in the child nodes. I'm sorry about that. I'll send out a patch this weekend to correct this. I have 'make dt_binding_check' in my local build script. Is there something else that I should be running as well? Or do you have a branch somewhere with your validation work that I can test my changes against? Brian