* [RESEND PATCH] staging: iio: ad7192: create of_device_id array
@ 2019-05-18 22:44 Bárbara Fernandes
2019-05-19 10:46 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Bárbara Fernandes @ 2019-05-18 22:44 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman
Cc: linux-iio, devel, linux-kernel, Bárbara Fernandes,
Wilson Sales
Create list of compatible device ids to be matched with those stated in
the device tree.
Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
Signed-off-by: Wilson Sales <spoonm@spoonm.org>
Co-developed by: Wilson Sales <spoonm@spoonm.org>
---
drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 3d74da9d37e7..cc886f944dbf 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
{"ad7195", ID_AD7195},
{}
};
+
+static const struct of_device_id ad7192_of_spi_match[] = {
+ { .compatible = "adi,ad7190" },
+ { .compatible = "adi,ad7192" },
+ { .compatible = "adi,ad7193" },
+ { .compatible = "adi,ad7195" },
+ {}
+};
+
+MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
+
MODULE_DEVICE_TABLE(spi, ad7192_id);
static struct spi_driver ad7192_driver = {
.driver = {
.name = "ad7192",
+ .of_match_table = ad7192_of_spi_match,
},
.probe = ad7192_probe,
.remove = ad7192_remove,
--
2.22.0.rc0.1.g337bb99195.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] staging: iio: ad7192: create of_device_id array
2019-05-18 22:44 [RESEND PATCH] staging: iio: ad7192: create of_device_id array Bárbara Fernandes
@ 2019-05-19 10:46 ` Jonathan Cameron
2019-05-20 10:22 ` Alexandru Ardelean
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-05-19 10:46 UTC (permalink / raw)
To: Bárbara Fernandes
Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Hartmut Knaack, Peter Meerwald-Stadler, Greg Kroah-Hartman,
linux-iio, devel, linux-kernel, Wilson Sales
On Sat, 18 May 2019 19:44:35 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> Co-developed by: Wilson Sales <spoonm@spoonm.org>
Hi Bárbara, Wilson,
One minor issue inline about code ordering.
Actual content is fine.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 3d74da9d37e7..cc886f944dbf 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> {"ad7195", ID_AD7195},
> {}
> };
> +
> +static const struct of_device_id ad7192_of_spi_match[] = {
> + { .compatible = "adi,ad7190" },
> + { .compatible = "adi,ad7192" },
> + { .compatible = "adi,ad7193" },
> + { .compatible = "adi,ad7195" },
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> +
Please keep the declaration of the table alongside the relevant
MODULE_DEVICE_TABLE.
In short, better to have your additions after this next line.
> MODULE_DEVICE_TABLE(spi, ad7192_id);
>
> static struct spi_driver ad7192_driver = {
> .driver = {
> .name = "ad7192",
> + .of_match_table = ad7192_of_spi_match,
> },
> .probe = ad7192_probe,
> .remove = ad7192_remove,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] staging: iio: ad7192: create of_device_id array
2019-05-19 10:46 ` Jonathan Cameron
@ 2019-05-20 10:22 ` Alexandru Ardelean
0 siblings, 0 replies; 3+ messages in thread
From: Alexandru Ardelean @ 2019-05-20 10:22 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Bárbara Fernandes, Lars-Peter Clausen, Michael Hennerich,
Stefan Popa, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, linux-iio, devel, LKML, Wilson Sales,
Alexandru Ardelean
On Sun, May 19, 2019 at 8:53 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 18 May 2019 19:44:35 -0300
> Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
>
I don't have anything else on top of what Jonathan added.
Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort
them out in the next weeks.
> > Create list of compatible device ids to be matched with those stated in
> > the device tree.
> >
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> > Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> > Co-developed by: Wilson Sales <spoonm@spoonm.org>
> Hi Bárbara, Wilson,
>
> One minor issue inline about code ordering.
> Actual content is fine.
>
> Thanks,
>
> Jonathan
>
> > ---
> > drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index 3d74da9d37e7..cc886f944dbf 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> > {"ad7195", ID_AD7195},
> > {}
> > };
> > +
> > +static const struct of_device_id ad7192_of_spi_match[] = {
> > + { .compatible = "adi,ad7190" },
> > + { .compatible = "adi,ad7192" },
> > + { .compatible = "adi,ad7193" },
> > + { .compatible = "adi,ad7195" },
> > + {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> > +
> Please keep the declaration of the table alongside the relevant
> MODULE_DEVICE_TABLE.
>
> In short, better to have your additions after this next line.
> > MODULE_DEVICE_TABLE(spi, ad7192_id);
> >
> > static struct spi_driver ad7192_driver = {
> > .driver = {
> > .name = "ad7192",
> > + .of_match_table = ad7192_of_spi_match,
> > },
> > .probe = ad7192_probe,
> > .remove = ad7192_remove,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-20 10:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-18 22:44 [RESEND PATCH] staging: iio: ad7192: create of_device_id array Bárbara Fernandes
2019-05-19 10:46 ` Jonathan Cameron
2019-05-20 10:22 ` Alexandru Ardelean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox