From: Wolfram Sang <wsa@the-dreams.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 1/2] eeprom: at24: use devm_i2c_new_dummy_device()
Date: Sun, 19 May 2019 22:52:35 +0200 [thread overview]
Message-ID: <20190519205235.GA19630@kunai> (raw)
In-Reply-To: <20190519204012.31861-2-brgl@bgdev.pl>
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
> Now that it's upstream, use the resource managed version
> of i2c_new_dummy().
That was fast :)
> - dummy_client = i2c_new_dummy(base_client->adapter,
> - base_client->addr + index);
> + dummy_client = devm_i2c_new_dummy_device(dev, base_client->adapter,
> + base_client->addr + index);
> if (!dummy_client) {
Oh well, the confusion starts already :/ devm_i2c_new_dummy_device()
returns an ERR_PTR.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-19 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 20:40 [PATCH 0/2] at24: use devm_i2c_new_dummy_device() Bartosz Golaszewski
2019-05-19 20:40 ` [PATCH 1/2] eeprom: " Bartosz Golaszewski
2019-05-19 20:52 ` Wolfram Sang [this message]
2019-05-20 6:14 ` Bartosz Golaszewski
2019-05-19 20:40 ` [PATCH 2/2] eeprom: at24: drop unnecessary label Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519205235.GA19630@kunai \
--to=wsa@the-dreams.de \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox