From: Shawn Guo <shawnguo@kernel.org>
To: Pramod Kumar <pramod.kumar_1@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"Michal.Vokac@ysoft.com" <Michal.Vokac@ysoft.com>,
Leo Li <leoyang.li@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ashish Kumar <ashish.kumar@nxp.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: nxp: frwy-ls1046a: add support for micron nor flash
Date: Mon, 20 May 2019 10:55:03 +0800 [thread overview]
Message-ID: <20190520025502.GK15856@dragon> (raw)
In-Reply-To: <20190510130207.14330-4-pramod.kumar_1@nxp.com>
On Fri, May 10, 2019 at 01:00:24PM +0000, Pramod Kumar wrote:
> add micron nor flash support for ls1046a frwy board.
>
> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
> Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
Prefix 'arm64: dts: frwy-ls1046a: ...' would be good enough.
> ---
> .../boot/dts/freescale/fsl-ls1046a-frwy.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> index de0d19c02944..890f07122dd0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> @@ -113,6 +113,23 @@
>
> };
>
> +
Unnecessary newline.
Shawn
> +&qspi {
> + num-cs = <1>;
> + bus-num = <0>;
> + status = "okay";
> +
> + qflash0: flash@0 {
> + compatible = "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <50000000>;
> + reg = <0>;
> + spi-rx-bus-width = <4>;
> + spi-tx-bus-width = <4>;
> + };
> +};
> +
> #include "fsl-ls1046-post.dtsi"
>
> &fman0 {
> --
> 2.17.1
>
prev parent reply other threads:[~2019-05-20 2:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 13:00 [PATCH v2 0/3] arm64: dts: nxp: add ls1046a frwy board support Pramod Kumar
2019-05-10 13:00 ` [PATCH v2 1/3] dt-bindings: arm: nxp: Add device tree binding for ls1046a-frwy board Pramod Kumar
2019-05-10 13:00 ` [PATCH v2 2/3] arm64: dts: nxp: add ls1046a-frwy board support Pramod Kumar
2019-05-20 2:53 ` Shawn Guo
2019-05-10 13:00 ` [PATCH v2 3/3] arm64: dts: nxp: frwy-ls1046a: add support for micron nor flash Pramod Kumar
2019-05-20 2:55 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520025502.GK15856@dragon \
--to=shawnguo@kernel.org \
--cc=Michal.Vokac@ysoft.com \
--cc=aisheng.dong@nxp.com \
--cc=ashish.kumar@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=pramod.kumar_1@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox