From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <lee.jones@linaro.org>
Cc: <arnd@arndb.de>, <natechancellor@gmail.com>,
<ottosabart@seberm.com>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: [PATCH 3/4] mfd: madera: Fix potential uninitialised use of variable
Date: Mon, 20 May 2019 10:06:27 +0100 [thread overview]
Message-ID: <20190520090628.29061-3-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20190520090628.29061-1-ckeepax@opensource.cirrus.com>
From: Stuart Henderson <stuarth@opensource.cirrus.com>
regmap_read won't set val to anything if an ACKed bus fails.
Signed-off-by: Stuart Henderson <stuarth@opensource.cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/mfd/madera-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 2a77988d04625..1b78c5c844a81 100644
--- a/drivers/mfd/madera-core.c
+++ b/drivers/mfd/madera-core.c
@@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(madera_name_from_type);
static int madera_wait_for_boot(struct madera *madera)
{
ktime_t timeout;
- unsigned int val;
+ unsigned int val = 0;
int ret = 0;
/*
--
2.11.0
next prev parent reply other threads:[~2019-05-20 9:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 9:06 [PATCH 1/4 RESEND] mfd: arizona: fix undefined behavior Charles Keepax
2019-05-20 9:06 ` [PATCH 2/4 RESEND] mfd: madera: Fix bad reference to pinctrl.txt file Charles Keepax
2019-05-27 13:52 ` Mauro Carvalho Chehab
2019-06-12 8:31 ` Lee Jones
2019-05-20 9:06 ` Charles Keepax [this message]
2019-06-12 8:31 ` [PATCH 3/4] mfd: madera: Fix potential uninitialised use of variable Lee Jones
2019-05-20 9:06 ` [PATCH 4/4] mfd: madera: Add supply mapping for MICVDD Charles Keepax
2019-06-12 8:32 ` Lee Jones
2019-06-12 8:31 ` [PATCH 1/4 RESEND] mfd: arizona: fix undefined behavior Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520090628.29061-3-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ottosabart@seberm.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox