Re: [PATCH] mlx5: avoid 64-bit division

Jason Gunthorpe
2019-05-29T16:08:04Z

On Mon, May 20, 2019 at 01:19:02PM +0200, Michal Kubecek wrote:
> Commit 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
> breaks i386 build by introducing three 64-bit divisions. As the divisor
> is MLX5_SW_ICM_BLOCK_SIZE() which is always a power of 2, we can replace
> the division with bit operations.
>
> Fixes: 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/cmd.c | 9 +++++++--
> drivers/infiniband/hw/mlx5/main.c | 2 +-
> 2 files changed, 8 insertions(+), 3 deletions(-)

Applied to for-rc, thanks

Jason