From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD00C072A4 for ; Mon, 20 May 2019 12:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 283BF204FD for ; Mon, 20 May 2019 12:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355893; bh=bUrpkPG9EvsqvYWC0sEWmB2EMOMb11lNz/mUWzxCLPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QKEmqQB4f9sZeawDwI3b4veXNfyQf/QBnBvPCcJDakuaX0x6nQo4e/iECXQ/jir9J JSKiKV6mV1GgtZpx7XicuCdRqZp4dieLZ9MsyL/kQ4nPUWt9/C5oLIEotriFXOWCVC VnuXD8KNkN8qctevEGcnK7FWAH0vFT6wLs4COXQc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391175AbfETMiM (ORCPT ); Mon, 20 May 2019 08:38:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:53598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391074AbfETMfX (ORCPT ); Mon, 20 May 2019 08:35:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4784720815; Mon, 20 May 2019 12:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355722; bh=bUrpkPG9EvsqvYWC0sEWmB2EMOMb11lNz/mUWzxCLPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MCPqiC28k32eaML/9N4j/EjIkMqahkpVlcpC0PKvWnCCJChz8YNPY/7wjZNFvTidX AJjjywd1KYKotmUTIIuyjolAcTGoD9l8F7uLRQstowG9p2xWDflKu69sJCMbl8z6Jd ZjDLgscgqAwVL1Zih+/sSzc6oQNyLutrqH0lN5eo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Ren , Jiufei Xue , Theodore Tso , Jan Kara , stable@kernel.org Subject: [PATCH 5.1 084/128] jbd2: check superblock mapped prior to committing Date: Mon, 20 May 2019 14:14:31 +0200 Message-Id: <20190520115255.230136659@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115249.449077487@linuxfoundation.org> References: <20190520115249.449077487@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiufei Xue commit 742b06b5628f2cd23cb51a034cb54dc33c6162c5 upstream. We hit a BUG at fs/buffer.c:3057 if we detached the nbd device before unmounting ext4 filesystem. The typical chain of events leading to the BUG: jbd2_write_superblock submit_bh submit_bh_wbc BUG_ON(!buffer_mapped(bh)); The block device is removed and all the pages are invalidated. JBD2 was trying to write journal superblock to the block device which is no longer present. Fix this by checking the journal superblock's buffer head prior to submitting. Reported-by: Eric Ren Signed-off-by: Jiufei Xue Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/jbd2/journal.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1350,6 +1350,10 @@ static int jbd2_write_superblock(journal journal_superblock_t *sb = journal->j_superblock; int ret; + /* Buffer got discarded which means block device got invalidated */ + if (!buffer_mapped(bh)) + return -EIO; + trace_jbd2_write_superblock(journal, write_flags); if (!(journal->j_flags & JBD2_BARRIER)) write_flags &= ~(REQ_FUA | REQ_PREFLUSH);