From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F69C04AAC for ; Mon, 20 May 2019 12:23:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D86C821479 for ; Mon, 20 May 2019 12:23:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388724AbfETMX5 convert rfc822-to-8bit (ORCPT ); Mon, 20 May 2019 08:23:57 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:59241 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388680AbfETMXy (ORCPT ); Mon, 20 May 2019 08:23:54 -0400 X-Originating-IP: 90.88.22.185 Received: from xps13 (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 36B8EFF810; Mon, 20 May 2019 12:23:34 +0000 (UTC) Date: Mon, 20 May 2019 14:23:33 +0200 From: Miquel Raynal To: masonccyang@mxic.com.tw Cc: bbrezillon@kernel.org, broonie@kernel.org, christophe.kerello@st.com, computersforpeace@gmail.com, devicetree@vger.kernel.org, dwmw2@infradead.org, geert@linux-m68k.org, juliensu@mxic.com.tw, lee.jones@linaro.org, liang.yang@amlogic.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, marcel.ziswiler@toradex.com, marek.vasut@gmail.com, mark.rutland@arm.com, paul.burton@mips.com, richard@nod.at, robh+dt@kernel.org, stefan@agner.ch, zhengxunli@mxic.com.tw Subject: Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller Message-ID: <20190520142333.390091d5@xps13> In-Reply-To: References: <1555320234-15802-1-git-send-email-masonccyang@mxic.com.tw> <1555320234-15802-3-git-send-email-masonccyang@mxic.com.tw> <20190512151820.4f2dd9da@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mason, masonccyang@mxic.com.tw wrote on Fri, 17 May 2019 17:30:21 +0800: > Hi Miquel, > > > > + > > > +static void mxic_nand_select_chip(struct nand_chip *chip, int chipnr) > > > > _select_target() is preferred now > > Do you mean I implement mxic_nand_select_target() to control #CS ? > > If so, I need to call mxic_nand_select_target( ) to control #CS ON > and then #CS OFF in _exec_op() due to nand_select_target() > is still calling chip->legacy.select_chip ? You must forget about the ->select_chip() callback. Now it should be handled directly from the controller driver. Please have a look at the commit pointed against the marvell_nand.c driver. [...] > > > + if (!mxic) > > > + return -ENOMEM; > > > + > > > + nand_chip = &mxic->nand; > > > + mtd = nand_to_mtd(nand_chip); > > > + mtd->dev.parent = pdev->dev.parent; > > > + nand_chip->ecc.priv = NULL; > > > + nand_set_flash_node(nand_chip, pdev->dev.parent->of_node); > > > + nand_chip->priv = mxic; > > > + > > > + mxic->mfd = mfd; > > > + > > > + nand_chip->legacy.select_chip = mxic_nand_select_chip; > > > > Please don't implement legacy interfaces. You can check in > > marvell_nand.c how this is handled now: > > > > b25251414f6e mtd: rawnand: marvell: Stop implementing ->select_chip() > > > > Does it mean chip->legacy.select_chip() will phase-out ? Yes it will. Thanks, Miquèl