From: Stephen Boyd <sboyd@kernel.org>
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>,
agross@kernel.org, david.brown@linaro.org,
gregkh@linuxfoundation.org
Cc: jslaby@suse.com, keescook@chromium.org, anton@enomsg.org,
ccross@android.com, tony.luck@intel.com,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, khasim.mohammed@linaro.org,
agsumit@qti.qualcomm.com
Subject: Re: [PATCH] tty: serial: msm_serial: Fix XON/XOFF
Date: Mon, 20 May 2019 08:03:19 -0700 [thread overview]
Message-ID: <20190520150320.5DBC520856@mail.kernel.org> (raw)
In-Reply-To: <f0c89b84-7c3d-596d-06e1-cb5172e62970@linaro.org>
Quoting Jorge Ramirez (2019-05-20 07:58:54)
> On 5/20/19 16:56, Jorge Ramirez wrote:
> >
> > yeah, semantically confusing msm_reset_dm_count is what really matters:
> > it tells the hardware to only take n bytes (in this case only one) so
> > the others will be ignored
>
> um after I said this, maybe iowrite32_rep should only be applied to
> uartdm ... what do you think?
>
Probably. The uartdm hardware typically required words everywhere while
the pre-dm hardware didn't. It's an if condition so it should be OK.
It may be time to remove non-uartdm support from this driver
all-together. From what I recall the only devices that are upstream are
the uartdm ones, so it may be easier to just remove the legacy stuff
that nobody has tested in many years.
next prev parent reply other threads:[~2019-05-20 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 10:34 [PATCH] tty: serial: msm_serial: Fix XON/XOFF Jorge Ramirez-Ortiz
2019-05-20 14:51 ` Stephen Boyd
2019-05-20 14:56 ` Jorge Ramirez
2019-05-20 14:58 ` Jorge Ramirez
2019-05-20 15:03 ` Stephen Boyd [this message]
2019-05-20 15:07 ` Jorge Ramirez
2019-05-20 15:11 ` Bjorn Andersson
2019-05-20 15:12 ` Bjorn Andersson
2019-05-20 15:20 ` Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520150320.5DBC520856@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=agsumit@qti.qualcomm.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=khasim.mohammed@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox