Re: [PATCH 2/2] Revert "mm, thp: restore node-local hugepage allocations"

David Rientjes
2019-05-29T21:24:38Z

On Thu, 23 May 2019, Andrew Morton wrote:

> > We are going in circles, *yes* there is a problem for potential swap
> > storms today because of the poor interaction between memory compaction and
> > directed reclaim but this is a result of a poor API that does not allow
> > userspace to specify that its workload really will span multiple sockets
> > so faulting remotely is the best course of action. The fix is not to
> > cause regressions for others who have implemented a userspace stack that
> > is based on the past 3+ years of long standing behavior or for specialized
> > workloads where it is known that it spans multiple sockets so we want some
> > kind of different behavior. We need to provide a clear and stable API to
> > define these terms for the page allocator that is independent of any
> > global setting of thp enabled, defrag, zone_reclaim_mode, etc. It's
> > workload dependent.
>
> um, who is going to do this work?
>
> Implementing a new API doesn't help existing userspace which is hurting
> from the problem which this patch addresses.
>

The problem which this patch addresses has apparently gone unreported for
4+ years since

commit 077fcf116c8c2bd7ee9487b645aa3b50368db7e1
Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Date: Wed Feb 11 15:27:12 2015 -0800

mm/thp: allocate transparent hugepages on local node

My goal is to reach a solution that does not cause anybody to incur
performance penalties as a result of it. It's surprising that such a
severe swap storm issue that went unnoticed for four years is something
that can't reach an amicable solution that doesn't cause other users to
regress.

> It does appear to me that this patch does more good than harm for the
> totality of kernel users, so I'm inclined to push it through and to try
> to talk Linus out of reverting it again.
>

(1) The totality of kernel users are not running workloads that span
multiple sockets, it's the minority, (2) it's changing 4+ year behavior
based on NUMA locality of hugepage allocations and provides no workarounds
for users who incur regressions as a result, and (3) does not solve the
underlying issue if remote memory is also fragmented or low on memory: it
actually makes the problem worse.

The easiest solution would be to define the MADV_HUGEPAGE behavior
explicitly in sysfs: local or remote. Defaut to local as the behavior
from the past four years and allow users to specify remote if their
workloads will span multiple sockets. This is somewhat coarse but no more
than the thp defrag setting in sysfs today that defines defrag behavior
for everybody on the system.