From: Christoph Hellwig <hch@lst.de>
To: xiaolinkui <xiaolinkui@kylinos.cn>
Cc: hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: target: use struct_size() in kmalloc()
Date: Tue, 21 May 2019 08:53:46 +0200 [thread overview]
Message-ID: <20190521065346.GG30402@lst.de> (raw)
In-Reply-To: <1558076615-8576-1-git-send-email-xiaolinkui@kylinos.cn>
Looks ok to me, although for a fixed size argument the whole overflow
detection thing in struct_size() is rather pointless..
prev parent reply other threads:[~2019-05-21 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 7:03 [PATCH] nvme: target: use struct_size() in kmalloc() xiaolinkui
2019-05-17 16:32 ` Chaitanya Kulkarni
2019-05-18 15:52 ` Gustavo A. R. Silva
2019-05-21 6:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521065346.GG30402@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=xiaolinkui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox