Re: [PATCH] arm: add missing include

Kees Cook
2019-05-21T20:23:54Z

On Tue, May 21, 2019 at 03:54:36PM +0000, Philippe Mazenauer wrote:
> Include corresponding header file <linux/elf-randomize.h> for function
> arch_randomize_brk().
>
> ../arch/arm/kernel/process.c:325:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
> unsigned long arch_randomize_brk(struct mm_struct *mm)
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>

Acked-by: Kees Cook <keescook@chromium.org>

> ---
> arch/arm/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 72cc0862a30e..73782012d403 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -23,6 +23,7 @@
> #include <linux/interrupt.h>
> #include <linux/init.h>
> #include <linux/elfcore.h>
> +#include <linux/elf-randomize.h>
> #include <linux/pm.h>
> #include <linux/tick.h>
> #include <linux/utsname.h>
> --
> 2.17.1
>

--
Kees Cook