public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	lkml <linux-kernel@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Discussions about the Letux Kernel 
	<letux-kernel@openphoenux.org>
Subject: Re: [BUG v5.2-rc1] ARM build broken
Date: Tue, 21 May 2019 13:36:21 -0700	[thread overview]
Message-ID: <201905211331.E0D1EDC0@keescook> (raw)
In-Reply-To: <A22646AB-300F-4E0A-95DE-06633C2A2986@goldelico.com>

On Tue, May 21, 2019 at 01:23:36PM +0200, H. Nikolaus Schaller wrote:
> >>>  HOSTLLD -shared scripts/gcc-plugins/arm_ssp_per_task_plugin.so - due to target missing
> >>> Undefined symbols for architecture x86_64:
> >>>  "gen_reg_rtx(machine_mode)", referenced from:
> >>>      (anonymous namespace)::arm_pertask_ssp_rtl_pass::execute() in arm_ssp_per_task_plugin.o

Are you seeing this error still, even after the fix I sent? Perhaps I
misunderstood that it solves all of the build issues?

> That seems to be a significant assumption about the build infrastructure
> which now became permanently enabled by the "default y" for GCC_PLUGINS.
> 
> I am not sure what the right way forward is. Probably for me it is to find
> out if I can fix my cross-toolchain. Or if the kernel should better check
> if gcc-plugins can really be built, if they are automatically enabled.
> Or keep all gcc-plugins disabled until explicitly configured for?

Right, that seems to be the case: it seems that the gcc plugin build
sanity detection script is not working in your environment. You can
check it directly.

Here's the bits from the Kconfig (though I added --show-error for you,
in case that's useful):

preferred-plugin-hostcc := $(if-success,[ $(gcc-version) -ge 40800 ],$(HOSTCXX),$(HOSTCC))

scripts/gcc-plugin.sh --show-error "$(preferred-plugin-hostcc)" "$(HOSTCXX)" "$(CC)"

I'm not sure what your kernel build picks for gcc-version, HOSTCXX
HOSTCC and CC...

-- 
Kees Cook

  reply	other threads:[~2019-05-21 20:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4DB08A04-D03A-4441-85DE-64A13E6D709C@goldelico.com>
2019-05-20 15:59 ` [BUG v5.2-rc1] ARM build broken Kees Cook
     [not found]   ` <D8F987B2-8F41-46DE-B298-89541D7A9774@goldelico.com>
2019-05-20 18:53     ` Kees Cook
2019-05-20 19:35       ` H. Nikolaus Schaller
2019-05-20 20:25         ` Kees Cook
2019-05-20 21:21       ` Chris Packham
2019-05-21 11:23         ` H. Nikolaus Schaller
2019-05-21 20:36           ` Kees Cook [this message]
2019-05-22  6:02             ` H. Nikolaus Schaller
2019-06-03  7:46               ` [Letux-kernel] " H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201905211331.E0D1EDC0@keescook \
    --to=keescook@chromium.org \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=ard.biesheuvel@linaro.org \
    --cc=hns@goldelico.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox