From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
John Whitmore <johnfwhitmore@gmail.com>,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check
Date: Wed, 22 May 2019 10:04:18 +0300 [thread overview]
Message-ID: <20190522070418.GP31203@kadam> (raw)
In-Reply-To: <20190521174221.124459-1-natechancellor@gmail.com>
On Tue, May 21, 2019 at 10:42:21AM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2663:47: warning:
> address of array 'param->u.wpa_ie.data' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> (param->u.wpa_ie.len && !param->u.wpa_ie.data))
> ~~~~~~~~~~~~~~~~~^~~~
>
> This was exposed by commit deabe03523a7 ("Staging: rtl8192u: ieee80211:
> Use !x in place of NULL comparisons") because we disable the warning
> that would have pointed out the comparison against NULL is also false:
>
Heh. Weird. Why would people disable one and not the other?
regards,
dan carpenter
next prev parent reply other threads:[~2019-05-22 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 17:42 [PATCH] staging: rtl8192u: Remove an unnecessary NULL check Nathan Chancellor
2019-05-21 22:53 ` Nick Desaulniers
2019-05-21 22:57 ` Nick Desaulniers
2019-05-22 9:24 ` Dan Carpenter
2019-05-22 7:04 ` Dan Carpenter [this message]
2019-05-22 20:39 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522070418.GP31203@kadam \
--to=dan.carpenter@oracle.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox