Re: [PATCH 04/12] mips: Reserve memory for the kernel image resources

Serge Semin
2019-05-03T17:21:18Z

Hello Paul

On Thu, May 02, 2019 at 06:45:39PM +0000, Paul Burton wrote:
> Hi Serge,
>
> On Thu, May 02, 2019 at 05:24:37PM +0300, Serge Semin wrote:
> > Just reviewed and tested your series on my machine. I tagged the whole series
> > in a response to the cover-letter of [1].
>
> Thanks for the review & testing; that series is now in mips-next.
>
> > Could you please proceed with this patchset review procedure? There are
> > also eight more patches left without your tag or comment. This patch
> > is also left with no explicit tag.
> >
> > BTW I see you already applied patches 1-3 to the mips-next, so what shall I
> > do when sending a v2 patchset with fixes asked to be provided for patch 12
> > and possibly for others in future? Shall I just resend the series without that
> > applied patches or send them over with your acked-by tagges?
>
> I've so far applied patches 1-7 of your series to mips-next, and stopped
> at patch 8 which has a comment to address.
>
> My preference would be if you could send a v2 which just contains the
> remaining patches (ie. patches 8-12 become patches 1-5), ideally atop
> the mips-next branch.
>
> The series looks good to me once the review comments are addressed, but
> no need to add an Acked-by - it'll be implicit when I apply them to
> mips-next.
>

Agreed. I'll do it shortly.

-Sergey

> Thanks,
> Paul