From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518BEC282DD for ; Wed, 22 May 2019 15:57:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 303A4216F4 for ; Wed, 22 May 2019 15:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729888AbfEVP5c (ORCPT ); Wed, 22 May 2019 11:57:32 -0400 Received: from verein.lst.de ([213.95.11.211]:40332 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729431AbfEVP5c (ORCPT ); Wed, 22 May 2019 11:57:32 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 35D7268B05; Wed, 22 May 2019 17:57:09 +0200 (CEST) Date: Wed, 22 May 2019 17:57:08 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Tom Murphy , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/24] iommu/dma: Move domain lookup into __iommu_dma_{map, unmap} Message-ID: <20190522155708.GA29904@lst.de> References: <20190520072948.11412-1-hch@lst.de> <20190520072948.11412-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 02:34:49PM +0100, Robin Murphy wrote: > On 20/05/2019 08:29, Christoph Hellwig wrote: >> From: Robin Murphy >> >> Most of the callers don't care, and the couple that do already have the >> domain to hand for other reasons are in slow paths where the (trivial) >> overhead of a repeated lookup will be utterly immaterial. >> >> Signed-off-by: Robin Murphy >> [hch: dropped the hunk touching iommu_dma_get_msi_page to avoid a >> conflict with another series] > > Since the MSI changes made it into 5.2, do you want to resurrect that hunk > here, or shall I spin it up as a follow-on patch? Either way is fine with me.