From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7EEC282CE for ; Wed, 22 May 2019 19:39:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6FB22081C for ; Wed, 22 May 2019 19:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553971; bh=dy+5KZ5Z6sM0uLoTtO033MuHDREOBbOfD0kSQTitNdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zolNMwOZWG4pMM2K0sVMmTfGxkwrdN6xu4TsIUSmZhhtL47+TJ38lsblUW/bxXDR5 IvrHGNyn/WDO3bQuv1sRTLYVCTl9nQkzUtt0bNHrENlG/WdPJ8PsCqygf6GL7I+BDd EYIj6GKz/Lnx4Q/YkTpL7GM8wsfv1S41CsFGy7k0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733210AbfEVTja (ORCPT ); Wed, 22 May 2019 15:39:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:52778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732976AbfEVT3k (ORCPT ); Wed, 22 May 2019 15:29:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 342D1204FD; Wed, 22 May 2019 19:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553379; bh=dy+5KZ5Z6sM0uLoTtO033MuHDREOBbOfD0kSQTitNdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yZwm7w6d9pt59wdRo0VX4mGLeOY5QcwMs1j3FEp3SJ8+nPKNKmyyG8q51F3p6Ieiu J5vw1VPfgRShg8Zu2T2pmf11JBcc/3PqfV4vA2icE1cQoeYuxvG//FCtNmJGbeSbwH YBFYmTNmMhySwgukBfk0u/LOeqCbJbLvUgAKp0EQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 039/167] net: cw1200: fix a NULL pointer dereference Date: Wed, 22 May 2019 15:26:34 -0400 Message-Id: <20190522192842.25858-39-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190522192842.25858-1-sashal@kernel.org> References: <20190522192842.25858-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit 0ed2a005347400500a39ea7c7318f1fea57fb3ca ] In case create_singlethread_workqueue fails, the fix free the hardware and returns NULL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/st/cw1200/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/st/cw1200/main.c b/drivers/net/wireless/st/cw1200/main.c index dc478cedbde0d..84624c812a15f 100644 --- a/drivers/net/wireless/st/cw1200/main.c +++ b/drivers/net/wireless/st/cw1200/main.c @@ -345,6 +345,11 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr, mutex_init(&priv->wsm_cmd_mux); mutex_init(&priv->conf_mutex); priv->workqueue = create_singlethread_workqueue("cw1200_wq"); + if (!priv->workqueue) { + ieee80211_free_hw(hw); + return NULL; + } + sema_init(&priv->scan.lock, 1); INIT_WORK(&priv->scan.work, cw1200_scan_work); INIT_DELAYED_WORK(&priv->scan.probe_work, cw1200_probe_work); -- 2.20.1