From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0E8C282CE for ; Wed, 22 May 2019 19:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FEA32089E for ; Wed, 22 May 2019 19:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553568; bh=3y4I0rUSwxML9pUm1vTUxrU9c0lu6C4aI58cHm3pulI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nRD3Fh5+R1ONvV5xe9ErChqykI0mJSJ5W2c13G0APX8qdCZRnu+1wmf5yWZxOqViU Dv06FuoQ5eIg9NgxCawUpSxX6aCvrFWNzIgXa0SNJ1SPD8ApMvKiL4e05yMmv6tuPp jzmnXSBTaVZgqyxUcW0o6OWPV6r8Y7rEm4WfzKho= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387764AbfEVTcH (ORCPT ); Wed, 22 May 2019 15:32:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732453AbfEVTcF (ORCPT ); Wed, 22 May 2019 15:32:05 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E99021473; Wed, 22 May 2019 19:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553525; bh=3y4I0rUSwxML9pUm1vTUxrU9c0lu6C4aI58cHm3pulI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Aqz18kokV4B/jLZaPmeQEPItQA+ScMC9bH/v5vJ9z/kCM8Bw/XCcciV8fL8RPv5DN 3txnMf/UAUNoYbPUIyn83zrtpBGv1rvCZc86AX6onh4IxpVcfjvbfuS2eEnweIieJR GlP/HKoiBBT1ZKJEZe93PB5+w5mRQ/Clrm8arDok= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sebastian Andrzej Siewior , kbuild test robot , Linus Torvalds , "Paul E . McKenney" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Sasha Levin Subject: [PATCH AUTOSEL 4.4 24/92] smpboot: Place the __percpu annotation correctly Date: Wed, 22 May 2019 15:30:19 -0400 Message-Id: <20190522193127.27079-24-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190522193127.27079-1-sashal@kernel.org> References: <20190522193127.27079-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sebastian Andrzej Siewior [ Upstream commit d4645d30b50d1691c26ff0f8fa4e718b08f8d3bb ] The test robot reported a wrong assignment of a per-CPU variable which it detected by using sparse and sent a report. The assignment itself is correct. The annotation for sparse was wrong and hence the report. The first pointer is a "normal" pointer and points to the per-CPU memory area. That means that the __percpu annotation has to be moved. Move the __percpu annotation to pointer which points to the per-CPU area. This change affects only the sparse tool (and is ignored by the compiler). Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: f97f8f06a49fe ("smpboot: Provide infrastructure for percpu hotplug threads") Link: http://lkml.kernel.org/r/20190424085253.12178-1-bigeasy@linutronix.de Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- include/linux/smpboot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/smpboot.h b/include/linux/smpboot.h index 12910cf19869c..12a4b09f4d08b 100644 --- a/include/linux/smpboot.h +++ b/include/linux/smpboot.h @@ -30,7 +30,7 @@ struct smpboot_thread_data; * @thread_comm: The base name of the thread */ struct smp_hotplug_thread { - struct task_struct __percpu **store; + struct task_struct * __percpu *store; struct list_head list; int (*thread_should_run)(unsigned int cpu); void (*thread_fn)(unsigned int cpu); -- 2.20.1