From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: David Kershner <david.kershner@unisys.com>,
Petr Machata <petrm@mellanox.com>,
David Ahern <dsahern@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jann Horn <jannh@google.com>,
sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: visornic: Replace GFP_ATOMIC with GFP_KERNEL
Date: Thu, 23 May 2019 09:17:13 +0200 [thread overview]
Message-ID: <20190523071713.GA24998@kroah.com> (raw)
In-Reply-To: <20190522170530.GA4331@hari-Inspiron-1545>
On Wed, May 22, 2019 at 10:35:30PM +0530, Hariprasad Kelam wrote:
> As per below information
>
> GFP_KERNEL FLAG
>
> This is a normal allocation and might block. This is the flag to use in
> process context code when it is safe to sleep.
>
> GFP_ATOMIC FLAG
>
> The allocation is high-priority and does not sleep. This is the flag to
> use in interrupt handlers, bottom halves and other situations where you
> cannot sleep
>
> And we can take advantage of GFP_KERNEL , as when system is in low
> memory chances of getting success is high compared to GFP_ATOMIC.
>
> As visornic_probe is in process context we can use GPF_KERNEL.
Ah, nice catch! Will go queue this up now, thanks.
greg k-h
prev parent reply other threads:[~2019-05-23 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 17:05 [PATCH] staging: unisys: visornic: Replace GFP_ATOMIC with GFP_KERNEL Hariprasad Kelam
2019-05-23 7:17 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523071713.GA24998@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=dsahern@gmail.com \
--cc=hariprasad.kelam@gmail.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox